FreeBSD fork of Phabricator code review
https://reviews.freebsd.org
425ab7a846
Summary: Adding class templates to `PhabricatorPolicyAwareQuery` and `PhabricatorCursorPagedPolicyAwareQuery` to make `execute()` have the right return signature, when the query classes are also annotated. Otherwise, the return type is inferred as `PhabricatorPolicyInterface` as before. Test Plan: Add some annotations to query classes and see that `$query->execute()` infers the more specific return type. Diviner still works after ./bin/diviner generate. For example this page still exist: /book/dev/class/PhabricatorCursorPagedPolicyAwareQuery/ And the method newResultObject() is now documented with the return type R|null. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26037 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Phorge is a collection of web applications which help software companies build better software.
Phorge is a community-maintained fork of Phabricator.
Phorge includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
Phorge is developed and maintained by The Phorge Team.
LICENSE
Phorge is released under the Apache 2.0 license except as otherwise noted.