minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Remove orphan CSS selectors in base/main-menu-view.css

Browse source 
Summary:
* `phabricator-application-menu-expanded`
** Added in https://we.phorge.it/rPfed0a2a496536d5a2a22f712861383299fabd3bd, usage removed in https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb from `src/view/page/menu/PhabricatorMainMenuView.php`
* `phabricator-core-menu-icon`
** Added in https://we.phorge.it/rPe3f6bbfff888008fcdf88f620b6716ab5add209b, usage removed in https://we.phorge.it/rP20035fe9a8ed53f4616528b114df61465f1d1f46 and https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb
* `phabricator-expand-search-menu`
** Added in https://we.phorge.it/rP919bd4a03499305093d8882952a9dd3dac1c55a9, usage removed in https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb from `src/view/page/menu/PhabricatorMainMenuView.php`
* `phabricator-main-menu-expand-button`
** Added in https://we.phorge.it/rP3c7944d297b2416d568ca2a7ab1e5c212adb78ff, usage removed in https://we.phorge.it/rP6f5dab634db26a14ba2ee000a3cee75c9d6152fb
* `phabricator-main-menu-group-logo`
** Added in https://we.phorge.it/rP3c7944d297b2416d568ca2a7ab1e5c212adb78ff, usage removed in https://we.phorge.it/rP54fe74d6216707267a1c818404507d2ee5ad82ad

Test Plan: Grep the code for each CSS selector (`grep --exclude="*.css" -R 'some-search-string' .`), also do partial searches, get no results.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25998
This commit is contained in:
Andre Klapper 2025-05-08 15:06:01 +02:00
parent f4f616410c
commit 0347f1f619
2 changed files with 8 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array(
'conpherence.pkg.css' => '79a197f6',
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '471c2d12',
'core.pkg.css' => '578670e1',
'core.pkg.js' => '086da722',
'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => 'db7c5008',
@ -37,7 +37,7 @@ return array(
'rsrc/css/aphront/typeahead.css' => '5da109c8',
'rsrc/css/application/almanac/almanac.css' => '2e050f4f',
'rsrc/css/application/auth/auth.css' => 'c2f23d74',
'rsrc/css/application/base/main-menu-view.css' => '741a6bba',
'rsrc/css/application/base/main-menu-view.css' => 'c731af7c',
'rsrc/css/application/base/notification-menu.css' => '4df1ee30',
'rsrc/css/application/base/phui-theme.css' => '35883b37',
'rsrc/css/application/base/standard-page-view.css' => '45aa515d',
@ -767,7 +767,7 @@ return array(
'phabricator-flag-css' => '2b77be8d',
'phabricator-keyboard-shortcut' => '1a844c06',
'phabricator-keyboard-shortcut-manager' => '81debc48',
'phabricator-main-menu-view' => '741a6bba',
'phabricator-main-menu-view' => 'c731af7c',
'phabricator-notification' => 'a9b91e3f',
'phabricator-notification-css' => '30240bd2',
'phabricator-notification-menu-css' => '4df1ee30',
@ -1557,9 +1557,6 @@ return array(
'javelin-stratcom',
'phabricator-tooltip',
),
'741a6bba' => array(
'phui-theme-css',
),
74446546 => array(
'javelin-behavior',
'javelin-dom',
@ -2010,6 +2007,9 @@ return array(
'javelin-workflow',
'javelin-json',
),
'c731af7c' => array(
'phui-theme-css',
),
'cc1553f3' => array(
'javelin-stratcom',
'javelin-request',

35
webroot/rsrc/css/application/base/main-menu-view.css
View file

@ -36,10 +36,6 @@
*/
.device-desktop .phabricator-main-menu-group-logo {
float: left;
}
.phabricator-main-menu-brand {
height: 44px;
float: left;
@ -102,13 +98,11 @@
line-height: 24px;
}
.phabricator-expand-application-menu,
.phabricator-expand-search-menu {
.phabricator-expand-application-menu {
float: right;
}
.device-desktop .phabricator-main-menu-search-button,
.device-desktop .phabricator-main-menu-expand-button {
.device-desktop .phabricator-main-menu-search-button {
display: none;
}
@ -336,11 +330,6 @@ a.phabricator-core-user-menu .caret:before {
font-weight: normal;
}
.device .phabricator-application-menu-expanded.phabricator-search-menu-expanded
.phabricator-search-menu {
padding: 0;
}
.device-phone .phabricator-main-search-typeahead-result .result-name {
font-size: {$biggestfontsize};
}
@ -527,26 +516,6 @@ a.phabricator-core-user-menu .caret:before {
margin-top: 4px;
}
.device-desktop .phabricator-core-menu-icon {
top: 4px;
left: 4px;
}
.device .phabricator-core-menu-icon {
left: 16px;
height: 24px;
width: 24px;
background-size: 24px;
margin: 2px;
}
.phabricator-core-menu-icon {
position: absolute;
display: block;
width: 28px;
height: 28px;
}
.phabricator-main-menu-dropdown.phui-list-sidenav {
position: absolute;
background: #fff;