f6214f060e
Summary: Starting with a new instance running PHP 8.2, address all exceptions that come up through some basic browsing/usage. For `strlen(null)` issues I generally tried to resolve if the value should be non-null at the point of issue, and attempt to address at earlier call-site. There were not many of these that I could determine. In the rest of those cases I would replace with a null-and-strlen check, or use `phutil_nonempty_string` if I was certain the value was a string and it was more convenient. Hitting all code-paths is challenging, so I would search for `strlen` within radius of files I was modifying and evaluate to address those uses in the same manner. Notes: - `AphrontRequest::getStr` only ever returns a string, and is safe to use `phutil_nonempty_string`. - `PhabricatorEnv::getEnvConfig` can return non-string things so any values coming from there should never use `phutil_nonempty_string`. - `AphrontRequest::getHTTPHeader` indicates it could return wild so `phutil_nonempty_string` should not be used. - `AphrontRequest::getURIData` isn't clear if it could return non-string data, so never use `phutil_nonempty_string`. Refs T13588 Test Plan: I'm running an instance on 8.2 and went through the basic setup/installation, startup and usage, including setup issues and configurations/settings. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: aklapper, Korvin, epriestley Maniphest Tasks: T13588 Differential Revision: https://secure.phabricator.com/D21862
45 lines
937 B
Plaintext
45 lines
937 B
Plaintext
# NOTE: Thinking about adding files created by your operating system, IDE,
|
|
# or text editor here? Don't! Add them to your per-user .gitignore instead.
|
|
|
|
# Diviner
|
|
/docs/
|
|
/.divinercache/
|
|
/src/.cache/
|
|
|
|
# libphutil
|
|
/src/.phutil_module_cache
|
|
|
|
# Configuration
|
|
/conf/custom/*
|
|
/conf/local/local.json
|
|
/conf/local/ENVIRONMENT
|
|
/conf/local/VERSION
|
|
/conf/keys/device.pub
|
|
/conf/keys/device.key
|
|
/conf/keys/device.id
|
|
/conf/aphlict/aphlict.custom.json
|
|
|
|
# Impact Font
|
|
/resources/font/impact.ttf
|
|
|
|
# User-accessible hook for adhoc debugging scripts
|
|
/support/debug.php
|
|
|
|
# User-accessible hook for adhoc startup code
|
|
/support/preamble.php
|
|
|
|
# Users can link binaries here
|
|
/support/bin/*
|
|
|
|
# User extensions
|
|
/src/extensions/*
|
|
|
|
# NPM local packages
|
|
/support/aphlict/server/node_modules/
|
|
/support/aphlict/server/package.json
|
|
/support/aphlict/server/package-lock.json
|
|
|
|
# Places for users to add custom resources.
|
|
/resources/cows/custom/*
|
|
/resources/figlet/custom/*
|