c13f9d157b
Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
108 lines
2.6 KiB
PHP
108 lines
2.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group console
|
|
*/
|
|
final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
|
|
|
|
protected $profileFilePHID;
|
|
|
|
public function getName() {
|
|
return 'XHProf';
|
|
}
|
|
|
|
public function getColor() {
|
|
$data = $this->getData();
|
|
if ($data['profileFilePHID']) {
|
|
return '#ff00ff';
|
|
}
|
|
return null;
|
|
}
|
|
|
|
public function getDescription() {
|
|
return 'Provides detailed PHP profiling information through XHProf.';
|
|
}
|
|
|
|
public function generateData() {
|
|
return array(
|
|
'profileFilePHID' => $this->profileFilePHID,
|
|
'profileURI' => (string)$this
|
|
->getRequestURI()
|
|
->alter('__profile__', 'page'),
|
|
);
|
|
}
|
|
|
|
public function getXHProfRunID() {
|
|
return $this->profileFilePHID;
|
|
}
|
|
|
|
public function renderPanel() {
|
|
$data = $this->getData();
|
|
|
|
$run = $data['profileFilePHID'];
|
|
$profile_uri = $data['profileURI'];
|
|
|
|
if (!DarkConsoleXHProfPluginAPI::isProfilerAvailable()) {
|
|
$href = PhabricatorEnv::getDoclink('article/Installation_Guide.html');
|
|
$install_guide = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
'class' => 'bright-link',
|
|
),
|
|
'Installation Guide');
|
|
return hsprintf(
|
|
'<div class="dark-console-no-content">'.
|
|
'The "xhprof" PHP extension is not available. Install xhprof '.
|
|
'to enable the XHProf console plugin. You can find instructions in '.
|
|
'the %s.'.
|
|
'</div>',
|
|
$install_guide);
|
|
}
|
|
|
|
$result = array();
|
|
|
|
$header = hsprintf(
|
|
'<div class="dark-console-panel-header">'.
|
|
'%s'.
|
|
'<h1>XHProf Profiler</h1>'.
|
|
'</div>',
|
|
phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $profile_uri,
|
|
'class' => $run
|
|
? 'disabled button'
|
|
: 'green button',
|
|
),
|
|
'Profile Page'));
|
|
$result[] = $header;
|
|
|
|
if ($run) {
|
|
$result[] = hsprintf(
|
|
'<a href="/xhprof/profile/%s/" '.
|
|
'class="bright-link" '.
|
|
'style="float: right; margin: 1em 2em 0 0;'.
|
|
'font-weight: bold;" '.
|
|
'target="_blank">Profile Permalink</a>'.
|
|
'<iframe src="/xhprof/profile/%s/?frame=true"></iframe>',
|
|
$run,
|
|
$run);
|
|
} else {
|
|
$result[] = hsprintf(
|
|
'<div class="dark-console-no-content">'.
|
|
'Profiling was not enabled for this page. Use the button above '.
|
|
'to enable it.'.
|
|
'</div>');
|
|
}
|
|
|
|
return phutil_implode_html("\n", $result);
|
|
}
|
|
|
|
|
|
public function willShutdown() {
|
|
$this->profileFilePHID = DarkConsoleXHProfPluginAPI::getProfileFilePHID();
|
|
}
|
|
|
|
}
|