FreeBSD fork of Phabricator code review
https://reviews.freebsd.org
b7ff9ba6f8
Summary: Phorge does not expose the location of the last call in unhandled exceptions on the web page. One has to open the error log or console to find the location. The error message in the yellow box comes directly from PHP's `$throwable->getMessage()`, and the stacktrace comes directly from PHP's `$throwable->getTrace()`. Thus manually concatenate the error message string with `$throwable->getFile()` and `$throwable->getLine()` to display the location of the last call but strip the absolute path not to expose server details. Closes T15689 Test Plan: Introduce a random PHP error and load the Phorge page. For example, add `$chart_view += $chart_panel;` in src/applications/project/controller/PhabricatorProjectReportsController.php and go to http://phorge.localhost/project/reports/1/ Reviewers: O1 Blessed Committers, mainframe98, valerio.bozzolan Reviewed By: O1 Blessed Committers, mainframe98, valerio.bozzolan Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15689 Differential Revision: https://we.phorge.it/D25955 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Phorge is a collection of web applications which help software companies build better software.
Phorge is a community-maintained fork of Phabricator.
Phorge includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
Phorge is developed and maintained by The Phorge Team.
LICENSE
Phorge is released under the Apache 2.0 license except as otherwise noted.