Summary: On a Workboard without any "Group by <something>", when moving a Task from a Column to another, in PHP 8.1 there was a crash caused by a null passed to `strlen()`. `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15373 Test Plan: Applied this change and afterwards dragging a Task card to another Column succeeded, with or without a "Group by <something>" query. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15373 Differential Revision: https://we.phorge.it/D25207
150 lines
4 KiB
PHP
150 lines
4 KiB
PHP
<?php
|
|
|
|
final class PhabricatorProjectMoveController
|
|
extends PhabricatorProjectController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $request->getViewer();
|
|
$id = $request->getURIData('id');
|
|
|
|
$request->validateCSRF();
|
|
|
|
$column_phid = $request->getStr('columnPHID');
|
|
$object_phid = $request->getStr('objectPHID');
|
|
|
|
$after_phids = $request->getStrList('afterPHIDs');
|
|
$before_phids = $request->getStrList('beforePHIDs');
|
|
|
|
$order = $request->getStr('order');
|
|
if (!strlen($order)) {
|
|
$order = PhabricatorProjectColumnNaturalOrder::ORDERKEY;
|
|
}
|
|
|
|
$ordering = PhabricatorProjectColumnOrder::getOrderByKey($order);
|
|
$ordering = id(clone $ordering)
|
|
->setViewer($viewer);
|
|
|
|
// When the Workboard view is "Group By <something>" the header provides
|
|
// that context in JSON form
|
|
$edit_header = null;
|
|
$raw_header = $request->getStr('header');
|
|
if (phutil_nonempty_string($raw_header)) {
|
|
$edit_header = phutil_json_decode($raw_header);
|
|
} else {
|
|
$edit_header = array();
|
|
}
|
|
|
|
$project = id(new PhabricatorProjectQuery())
|
|
->setViewer($viewer)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
))
|
|
->withIDs(array($id))
|
|
->executeOne();
|
|
if (!$project) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$cancel_uri = $this->getApplicationURI(
|
|
new PhutilURI(
|
|
urisprintf('board/%d/', $project->getID()),
|
|
array(
|
|
'order' => $order,
|
|
)));
|
|
|
|
$board_phid = $project->getPHID();
|
|
|
|
$object = id(new ManiphestTaskQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(array($object_phid))
|
|
->needProjectPHIDs(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
|
|
if (!$object) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$columns = id(new PhabricatorProjectColumnQuery())
|
|
->setViewer($viewer)
|
|
->withProjectPHIDs(array($project->getPHID()))
|
|
->needTriggers(true)
|
|
->execute();
|
|
|
|
$columns = mpull($columns, null, 'getPHID');
|
|
$column = idx($columns, $column_phid);
|
|
if (!$column) {
|
|
// User is trying to drop this object into a nonexistent column, just kick
|
|
// them out.
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$engine = id(new PhabricatorBoardLayoutEngine())
|
|
->setViewer($viewer)
|
|
->setBoardPHIDs(array($board_phid))
|
|
->setObjectPHIDs(array($object_phid))
|
|
->executeLayout();
|
|
|
|
$order_params = array(
|
|
'afterPHIDs' => $after_phids,
|
|
'beforePHIDs' => $before_phids,
|
|
);
|
|
|
|
$xactions = array();
|
|
$xactions[] = id(new ManiphestTransaction())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_COLUMNS)
|
|
->setNewValue(
|
|
array(
|
|
array(
|
|
'columnPHID' => $column->getPHID(),
|
|
) + $order_params,
|
|
));
|
|
|
|
$header_xactions = $ordering->getColumnTransactions(
|
|
$object,
|
|
$edit_header);
|
|
foreach ($header_xactions as $header_xaction) {
|
|
$xactions[] = $header_xaction;
|
|
}
|
|
|
|
$sounds = array();
|
|
if ($column->canHaveTrigger()) {
|
|
$trigger = $column->getTrigger();
|
|
if ($trigger) {
|
|
$trigger_xactions = $trigger->newDropTransactions(
|
|
$viewer,
|
|
$column,
|
|
$object);
|
|
foreach ($trigger_xactions as $trigger_xaction) {
|
|
$xactions[] = $trigger_xaction;
|
|
}
|
|
|
|
foreach ($trigger->getSoundEffects() as $effect) {
|
|
$sounds[] = $effect;
|
|
}
|
|
}
|
|
}
|
|
|
|
$editor = id(new ManiphestTransactionEditor())
|
|
->setActor($viewer)
|
|
->setContinueOnMissingFields(true)
|
|
->setContinueOnNoEffect(true)
|
|
->setContentSourceFromRequest($request)
|
|
->setCancelURI($cancel_uri);
|
|
|
|
$editor->applyTransactions($object, $xactions);
|
|
|
|
return $this->newCardResponse(
|
|
$board_phid,
|
|
$object_phid,
|
|
$ordering,
|
|
$sounds);
|
|
}
|
|
|
|
}
|