phorge/src
epriestley 72f149bf39 Require rows passed to "loadAllFromArray()" have unique keys
Summary:
See PHI1809, which identified a bug in Project search where queries with a large number of slugs could paginate improperly.

This change detects problems in this category: cases where multiple rows with the same ID are passed to "loadAllFromArray()". It's likely that all cases it detects are cases where a GROUP BY is missing.

Since this might have some false positives or detect some things which aren't fundamentally problematic, I'm planning to hold it until the next release.

Test Plan:
  - Reverted D21399, then created a project with multiple slugs and queried for one of them via "project.search". Hit this new exeception.
  - Browsed around a bit, didn't immediately catch any collateral damage.

Differential Revision: https://secure.phabricator.com/D21400
2020-08-12 09:05:14 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront When proxying HTTP repository responses from repository nodes, discard content description headers 2020-04-25 07:51:46 -07:00
applications Improve handle/status list display on devices in commit graph lists 2020-08-12 09:04:08 -07:00
docs Update tab completion doc 2020-06-15 13:27:18 +00:00
extensions
infrastructure Require rows passed to "loadAllFromArray()" have unique keys 2020-08-12 09:05:14 -07:00
view Fix some content/background overflow issues with commit graph lists 2020-08-12 09:04:09 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Improve handle/status list display on devices in commit graph lists 2020-08-12 09:04:08 -07:00