minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
FreeBSD fork of Phabricator code review https://reviews.freebsd.org
17077 commits 2 branches 0 tags 155 MiB
PHP 93.5%
JavaScript 4.1%
CSS 2.4%
Go to file
epriestley 5720a38cfe Correct Aphlict websocket URI construction after PHP8 compatibility changes 
Summary:
See D21862. Ref T13700. D21862 affected notification server URI generation behavior when a notification server client is configured with:

  1. no "path" argument; and
  2. "cluster.instance" not set.

Condition (1) is not true default, and condition (2) is not true in my local environment, so it was easy for this to slip through the cracks. Apply the change suggested in D21862.

Also fix a couple other string-null issues I caught locally.

Test Plan: Generated notification server URIs under various simulated local conditions (no instance, path set) and everything seemed to be working correctly.

Maniphest Tasks: T13700

Differential Revision: https://secure.phabricator.com/D21875
2023-11-13 11:04:04 -08:00
bin Remove the "ssh-auth-key" script 2019-10-28 17:52:37 -07:00
conf Remove an old digest in Celerity code and some obsolete configuration options 2019-01-04 13:43:38 -08:00
externals Addressing some PHP 8 incompatibilities - Remarkup 2023-05-28 23:11:56 -04:00
resources Update Slowvote poll status to use sensible string constants 2022-05-27 10:15:01 -07:00
scripts Addressing PHP8 incompatibilities - Miscellaneous 2023-05-30 12:06:16 -04:00
src Correct Aphlict websocket URI construction after PHP8 compatibility changes 2023-11-13 11:04:04 -08:00
support Addressing PHP8 incompatibilities - Miscellaneous 2023-05-30 12:06:16 -04:00
webroot Provide a simple "Attach File" explicit workflow for files referenced but not attached 2022-05-24 09:49:59 -07:00
.arcconfig Set "history.immutable" to "false" explicitly in .arcconfig 2016-08-03 08:12:49 -07:00
.arclint Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration 2021-12-16 15:24:21 -08:00
.arcunit Use the configuration driven unit test engine 2015-08-11 07:57:11 +10:00
.editorconfig Addressing some PHP 8 incompatibilities - Remarkup 2023-05-28 23:11:56 -04:00
.gitignore Addressing some PHP 8 incompatibilities 2023-05-24 17:10:12 -04:00
LICENSE Fix text lint issues 2015-02-12 07:00:13 +11:00
NOTICE Remove some "Phacility" and "epriestley" references 2021-07-08 10:46:17 -07:00
README.md Document Phabricator as no longer actively maintained 2021-05-29 13:58:22 -07:00

README.md

Effective June 1, 2021: Phabricator is no longer actively maintained.

Phabricator is a collection of web applications for software development.

LICENSE

Phabricator is released under the Apache 2.0 license except as otherwise noted.