Summary: Fixes T7382, specifically we were drawing double navs, removed those from each page and added the correct CSS rule. Test Plan: Test a number of people and profile pages with a footer set. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7382 Differential Revision: https://secure.phabricator.com/D11895
141 lines
3.6 KiB
PHP
141 lines
3.6 KiB
PHP
<?php
|
|
|
|
final class PhabricatorProjectColumnDetailController
|
|
extends PhabricatorProjectBoardController {
|
|
|
|
private $id;
|
|
private $projectID;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->projectID = $data['projectID'];
|
|
$this->id = idx($data, 'id');
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$project = id(new PhabricatorProjectQuery())
|
|
->setViewer($viewer)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
))
|
|
->withIDs(array($this->projectID))
|
|
->needImages(true)
|
|
->executeOne();
|
|
|
|
if (!$project) {
|
|
return new Aphront404Response();
|
|
}
|
|
$this->setProject($project);
|
|
|
|
$column = id(new PhabricatorProjectColumnQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($this->id))
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
))
|
|
->executeOne();
|
|
if (!$column) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$timeline = $this->buildTransactionTimeline(
|
|
$column,
|
|
new PhabricatorProjectColumnTransactionQuery());
|
|
$timeline->setShouldTerminate(true);
|
|
|
|
$title = pht('%s', $column->getDisplayName());
|
|
|
|
$header = $this->buildHeaderView($column);
|
|
$actions = $this->buildActionView($column);
|
|
$properties = $this->buildPropertyView($column, $actions);
|
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
->setHeader($header)
|
|
->addPropertyList($properties);
|
|
|
|
$nav = $this->buildIconNavView($project);
|
|
$nav->appendChild($box);
|
|
$nav->appendChild($timeline);
|
|
|
|
return $this->buildApplicationPage(
|
|
$nav,
|
|
array(
|
|
'title' => $title,
|
|
));
|
|
}
|
|
|
|
private function buildHeaderView(PhabricatorProjectColumn $column) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setUser($viewer)
|
|
->setHeader($column->getDisplayName())
|
|
->setPolicyObject($column);
|
|
|
|
if ($column->isHidden()) {
|
|
$header->setStatus('fa-ban', 'dark', pht('Hidden'));
|
|
}
|
|
|
|
return $header;
|
|
}
|
|
|
|
private function buildActionView(PhabricatorProjectColumn $column) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$id = $column->getID();
|
|
$project_id = $this->getProject()->getID();
|
|
$base_uri = '/board/'.$project_id.'/';
|
|
|
|
$actions = id(new PhabricatorActionListView())
|
|
->setObjectURI($this->getApplicationURI($base_uri.'column/'.$id.'/'))
|
|
->setUser($viewer);
|
|
|
|
$can_edit = PhabricatorPolicyFilter::hasCapability(
|
|
$viewer,
|
|
$column,
|
|
PhabricatorPolicyCapability::CAN_EDIT);
|
|
|
|
$actions->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Edit Column'))
|
|
->setIcon('fa-pencil')
|
|
->setHref($this->getApplicationURI($base_uri.'edit/'.$id.'/'))
|
|
->setDisabled(!$can_edit)
|
|
->setWorkflow(!$can_edit));
|
|
|
|
return $actions;
|
|
}
|
|
|
|
private function buildPropertyView(
|
|
PhabricatorProjectColumn $column,
|
|
PhabricatorActionListView $actions) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$properties = id(new PHUIPropertyListView())
|
|
->setUser($viewer)
|
|
->setObject($column)
|
|
->setActionList($actions);
|
|
|
|
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
|
|
$viewer,
|
|
$column);
|
|
|
|
$properties->addProperty(
|
|
pht('Editable By'),
|
|
$descriptions[PhabricatorPolicyCapability::CAN_EDIT]);
|
|
|
|
|
|
$limit = $column->getPointLimit();
|
|
$properties->addProperty(
|
|
pht('Point Limit'),
|
|
$limit ? $limit : pht('No Limit'));
|
|
|
|
return $properties;
|
|
}
|
|
|
|
}
|