FreeBSD fork of Phabricator code review https://reviews.freebsd.org
Go to file
Andre Klapper 2574b0d118 Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs
Summary:
When being in fullscreen editor mode, the `Upload File` and `Meme` dialogs get opened behind the editor and thus are invisible.
Given the options listed in https://secure.phabricator.com/T8200, pop out of fullscreen when these buttons get clicked, as this is easiest to implement.

Closes T15901

Test Plan:
1. Go to any item which allows commenting, e.g. a task.
2. In the toolbar of the textarea, click the `Fullscreen Mode` button.
3. Click the `Upload File` or `Meme` button in the toolbar.
4. Check if the dialog is displayed.
6. Repeat the test in normal mode (not "Fullscreen mode") and see that it still works.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Tags: #remarkup

Maniphest Tasks: T15901

Differential Revision: https://we.phorge.it/D25764
2025-02-16 19:57:08 +01:00
bin Remove the "ssh-auth-key" script 2019-10-28 17:52:37 -07:00
conf Change some instances of "phabricator" to "phorge" 2023-11-18 22:14:15 +00:00
externals Add first unit test for mimemailparser headers 2024-12-06 13:12:54 +01:00
resources Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs 2025-02-16 19:57:08 +01:00
scripts Add first unit test for mimemailparser headers 2024-12-06 13:12:54 +01:00
src Unbreak the creation of Packages Versions 2025-02-16 17:44:35 +01:00
support Replace some Phabricator references in PhabricatorStartup.php on comments and errors 2025-02-07 16:41:52 +01:00
webroot Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs 2025-02-16 19:57:08 +01:00
.arcconfig T15006: Update .arcconfig to point to we.phorge.it 2021-06-18 14:51:47 -04:00
.arclint Calendar Import: add unit tests to cover participants 2024-08-28 09:31:18 +02:00
.arcunit Use the configuration driven unit test engine 2015-08-11 07:57:11 +10:00
.editorconfig
.gitignore Generate Diviner book for Javelin 2023-08-30 11:20:12 -07:00
LICENSE
NOTICE Remove some "Phacility" and "epriestley" references 2021-07-08 10:46:17 -07:00
README.md Update Readme 2021-06-18 11:36:31 -04:00

Phorge is a collection of web applications which help software companies build better software.

Phorge is a community-maintained fork of Phabricator.

Phorge includes applications for:

  • reviewing and auditing source code;
  • hosting and browsing repositories;
  • tracking bugs;
  • managing projects;
  • conversing with team members;
  • assembling a party to venture forth;
  • writing stuff down and reading it later;
  • hiding stuff from coworkers; and
  • also some other things.

Phorge is developed and maintained by The Phorge Team.


LICENSE

Phorge is released under the Apache 2.0 license except as otherwise noted.