From fc893658b8b668850fd349457aaf95c0670a0416 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 4 Sep 2017 09:20:10 -0700 Subject: [PATCH] Update menu item names for Applications -> Favorites Summary: Adds a `MenuName` method to applications that `ProfileMenuItem` uses instead of the application name if set. This improves the home/menu/new user experience at little cost. Also renamed the label from Applications to Favorites, since this menu gets altered to provide more than just applications. This also allows instances to set back to Maniphest if they so choose. Overall I think this direction resolves 95% of my concerns, with maybe a small potential downside which I don't really anticipate. We already name Dashboard panels by their object, and that hasn't really caused confusion. I think these links are similar. I click 'Tasks' and get presented a list of my tasks from Maniphest. Test Plan: Review each of the name changes as a default new install and a modified install. Reviewers: epriestley, amckinley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18524 --- src/applications/base/PhabricatorApplication.php | 4 ++++ .../application/PhabricatorDifferentialApplication.php | 6 +++++- .../application/PhabricatorDiffusionApplication.php | 4 ++++ .../home/engine/PhabricatorHomeProfileMenuEngine.php | 2 +- .../application/PhabricatorManiphestApplication.php | 4 ++++ .../phame/application/PhabricatorPhameApplication.php | 6 +++++- .../pholio/application/PhabricatorPholioApplication.php | 4 ++++ .../application/PhabricatorPhrictionApplication.php | 6 +++++- .../menuitem/PhabricatorApplicationProfileMenuItem.php | 2 +- 9 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php index f525d0ec97..72b577771f 100644 --- a/src/applications/base/PhabricatorApplication.php +++ b/src/applications/base/PhabricatorApplication.php @@ -57,6 +57,10 @@ abstract class PhabricatorApplication abstract public function getName(); + public function getMenuName() { + return $this->getName(); + } + public function getShortDescription() { return pht('%s Application', $this->getName()); } diff --git a/src/applications/differential/application/PhabricatorDifferentialApplication.php b/src/applications/differential/application/PhabricatorDifferentialApplication.php index e259c2f112..1c8926f585 100644 --- a/src/applications/differential/application/PhabricatorDifferentialApplication.php +++ b/src/applications/differential/application/PhabricatorDifferentialApplication.php @@ -10,8 +10,12 @@ final class PhabricatorDifferentialApplication extends PhabricatorApplication { return pht('Differential'); } + public function getMenuName() { + return pht('Code Review'); + } + public function getShortDescription() { - return pht('Review Code'); + return pht('Pre-Commit Review'); } public function getIcon() { diff --git a/src/applications/diffusion/application/PhabricatorDiffusionApplication.php b/src/applications/diffusion/application/PhabricatorDiffusionApplication.php index b00fcce77f..cf9c14aa8b 100644 --- a/src/applications/diffusion/application/PhabricatorDiffusionApplication.php +++ b/src/applications/diffusion/application/PhabricatorDiffusionApplication.php @@ -6,6 +6,10 @@ final class PhabricatorDiffusionApplication extends PhabricatorApplication { return pht('Diffusion'); } + public function getMenuName() { + return pht('Repositories'); + } + public function getShortDescription() { return pht('Host and Browse Repositories'); } diff --git a/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php b/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php index cbfe62aaa6..e380af2b6a 100644 --- a/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php +++ b/src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php @@ -49,7 +49,7 @@ final class PhabricatorHomeProfileMenuEngine $items[] = $this->newItem() ->setBuiltinKey(PhabricatorHomeConstants::ITEM_APPS_LABEL) ->setMenuItemKey(PhabricatorLabelProfileMenuItem::MENUITEMKEY) - ->setMenuItemProperties(array('name' => pht('Applications'))); + ->setMenuItemProperties(array('name' => pht('Favorites'))); foreach ($applications as $application) { if (!$application->isPinnedByDefault($viewer)) { diff --git a/src/applications/maniphest/application/PhabricatorManiphestApplication.php b/src/applications/maniphest/application/PhabricatorManiphestApplication.php index 6cb9626d5a..3076354599 100644 --- a/src/applications/maniphest/application/PhabricatorManiphestApplication.php +++ b/src/applications/maniphest/application/PhabricatorManiphestApplication.php @@ -6,6 +6,10 @@ final class PhabricatorManiphestApplication extends PhabricatorApplication { return pht('Maniphest'); } + public function getMenuName() { + return pht('Tasks'); + } + public function getShortDescription() { return pht('Tasks and Bugs'); } diff --git a/src/applications/phame/application/PhabricatorPhameApplication.php b/src/applications/phame/application/PhabricatorPhameApplication.php index 677872ba1e..f9ee2831b2 100644 --- a/src/applications/phame/application/PhabricatorPhameApplication.php +++ b/src/applications/phame/application/PhabricatorPhameApplication.php @@ -6,6 +6,10 @@ final class PhabricatorPhameApplication extends PhabricatorApplication { return pht('Phame'); } + public function getMenuName() { + return pht('Blogs'); + } + public function getBaseURI() { return '/phame/'; } @@ -15,7 +19,7 @@ final class PhabricatorPhameApplication extends PhabricatorApplication { } public function getShortDescription() { - return pht('Blog'); + return pht('Internal and External Blogs'); } public function getTitleGlyph() { diff --git a/src/applications/pholio/application/PhabricatorPholioApplication.php b/src/applications/pholio/application/PhabricatorPholioApplication.php index 4d80dd12ae..4afaeba263 100644 --- a/src/applications/pholio/application/PhabricatorPholioApplication.php +++ b/src/applications/pholio/application/PhabricatorPholioApplication.php @@ -6,6 +6,10 @@ final class PhabricatorPholioApplication extends PhabricatorApplication { return pht('Pholio'); } + public function getMenuName() { + return pht('Design Review'); + } + public function getBaseURI() { return '/pholio/'; } diff --git a/src/applications/phriction/application/PhabricatorPhrictionApplication.php b/src/applications/phriction/application/PhabricatorPhrictionApplication.php index d0eb46a069..1b06fd197c 100644 --- a/src/applications/phriction/application/PhabricatorPhrictionApplication.php +++ b/src/applications/phriction/application/PhabricatorPhrictionApplication.php @@ -6,10 +6,14 @@ final class PhabricatorPhrictionApplication extends PhabricatorApplication { return pht('Phriction'); } - public function getShortDescription() { + public function getMenuName() { return pht('Wiki'); } + public function getShortDescription() { + return pht('Wiki Documents'); + } + public function getBaseURI() { return '/w/'; } diff --git a/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php index aa42d56cfb..40275a8d7a 100644 --- a/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php +++ b/src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php @@ -31,7 +31,7 @@ final class PhabricatorApplicationProfileMenuItem return $name; } - return $application->getName(); + return $application->getMenuName(); } public function buildEditEngineFields(