minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Use panels for spacing in Maniphest.

Browse source 
Summary: Trying to move move content areas to panelview for consistency in spacing.

Test Plan: Reload Maniphest pages, see equal spacing like on Differential.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4527
This commit is contained in:
Chad Little 2013-01-18 18:19:56 -08:00
parent 6c44e704b5
commit f7cc0886a0
3 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/__celerity_resource_map__.php
View file

@ -2321,7 +2321,7 @@ celerity_register_resource_map(array(
), ),
'maniphest-task-summary-css' => 'maniphest-task-summary-css' =>
array( array(
'uri' => '/res/13a9468b/rsrc/css/application/maniphest/task-summary.css', 'uri' => '/res/466c0026/rsrc/css/application/maniphest/task-summary.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3432,7 +3432,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/fbeded59/javelin.pkg.js', 'uri' => '/res/pkg/fbeded59/javelin.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'a88951d1' => '2a1ed97f' =>
array( array(
'name' => 'maniphest.pkg.css', 'name' => 'maniphest.pkg.css',
'symbols' => 'symbols' =>
@ -3442,7 +3442,7 @@ celerity_register_resource_map(array(
2 => 'aphront-attached-file-view-css', 2 => 'aphront-attached-file-view-css',
3 => 'phabricator-project-tag-css', 3 => 'phabricator-project-tag-css',
), ),
'uri' => '/res/pkg/a88951d1/maniphest.pkg.css', 'uri' => '/res/pkg/2a1ed97f/maniphest.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'7707de41' => '7707de41' =>
@ -3462,7 +3462,7 @@ celerity_register_resource_map(array(
), ),
'reverse' => 'reverse' =>
array( array(
'aphront-attached-file-view-css' => 'a88951d1', 'aphront-attached-file-view-css' => '2a1ed97f',
'aphront-crumbs-view-css' => '7e7a7582', 'aphront-crumbs-view-css' => '7e7a7582',
'aphront-dialog-view-css' => '7e7a7582', 'aphront-dialog-view-css' => '7e7a7582',
'aphront-error-view-css' => '7e7a7582', 'aphront-error-view-css' => '7e7a7582',
@ -3560,8 +3560,8 @@ celerity_register_resource_map(array(
'javelin-vector' => 'fbeded59', 'javelin-vector' => 'fbeded59',
'javelin-workflow' => 'fbeded59', 'javelin-workflow' => 'fbeded59',
'lightbox-attachment-css' => '7e7a7582', 'lightbox-attachment-css' => '7e7a7582',
'maniphest-task-summary-css' => 'a88951d1', 'maniphest-task-summary-css' => '2a1ed97f',
'maniphest-transaction-detail-css' => 'a88951d1', 'maniphest-transaction-detail-css' => '2a1ed97f',
'phabricator-busy' => 'c90b892e', 'phabricator-busy' => 'c90b892e',
'phabricator-content-source-view-css' => 'ec01d039', 'phabricator-content-source-view-css' => 'ec01d039',
'phabricator-core-buttons-css' => '7e7a7582', 'phabricator-core-buttons-css' => '7e7a7582',
@ -3588,7 +3588,7 @@ celerity_register_resource_map(array(
'phabricator-object-selector-css' => 'ec01d039', 'phabricator-object-selector-css' => 'ec01d039',
'phabricator-paste-file-upload' => 'c90b892e', 'phabricator-paste-file-upload' => 'c90b892e',
'phabricator-prefab' => 'c90b892e', 'phabricator-prefab' => 'c90b892e',
'phabricator-project-tag-css' => 'a88951d1', 'phabricator-project-tag-css' => '2a1ed97f',
'phabricator-remarkup-css' => '7e7a7582', 'phabricator-remarkup-css' => '7e7a7582',
'phabricator-shaped-request' => 'ac53d36a', 'phabricator-shaped-request' => 'ac53d36a',
'phabricator-side-menu-view-css' => '7e7a7582', 'phabricator-side-menu-view-css' => '7e7a7582',

12
src/applications/maniphest/controller/ManiphestTaskListController.php
View file

@ -347,7 +347,7 @@ final class ManiphestTaskListController extends ManiphestController {
$count = number_format(count($list)); $count = number_format(count($list));
$lists->appendChild( $header =
javelin_render_tag( javelin_render_tag(
'h1', 'h1',
array( array(
@ -357,9 +357,15 @@ final class ManiphestTaskListController extends ManiphestController {
'priority' => head($list)->getPriority(), 'priority' => head($list)->getPriority(),
), ),
), ),
phutil_escape_html($group).' ('.$count.')')); phutil_escape_html($group).' ('.$count.')');
$lists->appendChild($task_list);
$panel = new AphrontPanelView();
$panel->appendChild($header);
$panel->appendChild($task_list);
$panel->setNoBackground();
$lists->appendChild($panel);
} }
$lists->appendChild('</div>'); $lists->appendChild('</div>');
$selector->appendChild($lists); $selector->appendChild($lists);

10
webroot/rsrc/css/application/maniphest/task-summary.css
View file

@ -146,7 +146,7 @@
} }
.maniphest-batch-editor { .maniphest-batch-editor {
margin: 1em 1em; margin: 20px;
} }
.maniphest-batch-editor-layout { .maniphest-batch-editor-layout {
@ -177,14 +177,6 @@
width: 100%; width: 100%;
} }
.maniphest-list-container {
padding: 0 1em;
}
.maniphest-group-container {
padding: 0 1em 1em;
}
td.maniphest-active-handle { td.maniphest-active-handle {
cursor: move; cursor: move;
background-image: url('/rsrc/image/grippy_texture.png'); background-image: url('/rsrc/image/grippy_texture.png');