minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Fix an inverted condition for the "Reopen Revision" action

Browse source 
Summary: Ref T2543. I converted this condition the wrong way, missing a `!`. I'll cherry-pick this to `stable`.

Test Plan: No more "Reopen Revision" action available on open revisions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18399
This commit is contained in:
epriestley 2017-08-11 09:47:30 -07:00
parent 153e4d8a38
commit ef8d4e2126
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
View file

@ -39,7 +39,7 @@ final class DifferentialRevisionReopenTransaction
} }
protected function validateAction($object, PhabricatorUser $viewer) { protected function validateAction($object, PhabricatorUser $viewer) {
if ($object->isPublished()) { if (!$object->isPublished()) {
throw new Exception( throw new Exception(
pht( pht(
'You can not reopen this revision because it is not closed. '. 'You can not reopen this revision because it is not closed. '.