Modernize Countdown

Summary: Update to new modern methods.

Test Plan: View List, New Countdown, Edit Countdown, Delete Countdown

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9690

Differential Revision: https://secure.phabricator.com/D14593
This commit is contained in:
Chad Little 2015-11-28 15:41:29 -08:00
parent 5686fb7fa4
commit ee102c7aca
4 changed files with 27 additions and 50 deletions

View file

@ -2,27 +2,9 @@
abstract class PhabricatorCountdownController extends PhabricatorController { abstract class PhabricatorCountdownController extends PhabricatorController {
public function buildSideNavView($for_app = false) {
$user = $this->getRequest()->getUser();
$nav = new AphrontSideNavFilterView();
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
if ($for_app) {
$nav->addFilter('create', pht('Create Countdown'));
}
id(new PhabricatorCountdownSearchEngine())
->setViewer($user)
->addNavigationItems($nav->getMenu());
$nav->selectFilter(null);
return $nav;
}
public function buildApplicationMenu() { public function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu(); return $this->newApplicationMenu()
->setSearchEngine(new PhabricatorCountdownSearchEngine());
} }
protected function buildApplicationCrumbs() { protected function buildApplicationCrumbs() {

View file

@ -184,13 +184,12 @@ final class PhabricatorCountdownEditController
->setFormErrors($errors) ->setFormErrors($errors)
->setForm($form); ->setForm($form);
return $this->buildApplicationPage( return $this->newPage()
->setTitle($page_title)
->setCrumbs($crumbs)
->appendChild(
array( array(
$crumbs,
$form_box, $form_box,
),
array(
'title' => $page_title,
)); ));
} }

View file

@ -8,15 +8,9 @@ final class PhabricatorCountdownListController
} }
public function handleRequest(AphrontRequest $request) { public function handleRequest(AphrontRequest $request) {
$querykey = $request->getURIData('queryKey'); return id(new PhabricatorCountdownSearchEngine())
->setController($this)
$controller = id(new PhabricatorApplicationSearchController()) ->buildResponse();
->setQueryKey($querykey)
->setSearchEngine(new PhabricatorCountdownSearchEngine())
->setNavigation($this->buildSideNavView());
return $this->delegateToController($controller);
} }
} }

View file

@ -61,19 +61,21 @@ final class PhabricatorCountdownViewController
$add_comment = $this->buildCommentForm($countdown); $add_comment = $this->buildCommentForm($countdown);
$content = array(
$crumbs,
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setPageObjectPHIDs(
array(
$countdown->getPHID(),
))
->appendChild(
array(
$object_box, $object_box,
$countdown_view, $countdown_view,
$timeline, $timeline,
$add_comment, $add_comment,
);
return $this->buildApplicationPage(
$content,
array(
'title' => $title,
'pageObjects' => array($countdown->getPHID()),
)); ));
} }