From ea376685ae9e539efd1b8063cc4703f9354549b0 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Sun, 5 Apr 2015 22:29:39 +1000 Subject: [PATCH] Fix some odd looking arrays Summary: These arrays looks a little odd, most likely due to the autofix applied by `ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR`. See D12296 in which I attempt to improve the autocorrection from this linter rule. Test Plan: N/A Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D12281 --- .../autopatches/20141222.maniphestprojtxn.php | 3 ++- ...AuthManagementTrustOAuthClientWorkflow.php | 3 ++- ...thManagementUntrustOAuthClientWorkflow.php | 3 ++- .../base/controller/PhabricatorController.php | 3 ++- .../PhabricatorConduitAPIController.php | 6 ++++-- .../check/PhabricatorBinariesSetupCheck.php | 21 ++++++++++++------- .../__tests__/ConpherenceTestCase.php | 6 ++++-- .../controller/ConpherenceListController.php | 3 ++- .../query/ConpherenceThreadSearchEngine.php | 3 ++- .../conpherence/storage/ConpherenceThread.php | 3 ++- .../view/ConpherenceDurableColumnView.php | 13 +++++++----- .../PhabricatorDifferentialApplication.php | 3 ++- ...DifferentialCreateDiffConduitAPIMethod.php | 6 ++++-- ...ferentialCreateRawDiffConduitAPIMethod.php | 6 ++++-- ...erentialRevisionCloseDetailsController.php | 6 ++++-- .../mail/DifferentialCreateMailReceiver.php | 3 ++- .../PhabricatorFilesApplication.php | 3 ++- .../PhabricatorManiphestApplication.php | 3 ++- .../PhabricatorPasteApplication.php | 3 ++- .../PhrictionDocumentController.php | 3 ++- .../editor/PhrictionTransactionEditor.php | 6 ++++-- .../config/PhabricatorPolicyConfigOptions.php | 3 ++- ...licationTransactionShowOlderController.php | 3 ++- .../view/PhabricatorInlineSummaryView.php | 3 ++- src/view/control/AphrontTableView.php | 3 ++- src/view/form/control/AphrontFormControl.php | 3 ++- .../layout/PhabricatorTransactionView.php | 6 ++++-- src/view/phui/PHUIDocumentView.php | 3 ++- src/view/phui/PHUIObjectBoxView.php | 3 ++- src/view/phui/PHUIObjectItemView.php | 3 ++- src/view/phui/PHUITimelineEventView.php | 6 ++++-- 31 files changed, 95 insertions(+), 50 deletions(-) diff --git a/resources/sql/autopatches/20141222.maniphestprojtxn.php b/resources/sql/autopatches/20141222.maniphestprojtxn.php index 985fb1421b..1fa5726fa4 100644 --- a/resources/sql/autopatches/20141222.maniphestprojtxn.php +++ b/resources/sql/autopatches/20141222.maniphestprojtxn.php @@ -6,7 +6,8 @@ $conn_w = $table->establishConnection('w'); echo "Converting Maniphest project transactions to modern EDGE ". "transactions...\n"; $metadata = array( - 'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,); + 'edge:type' => PhabricatorProjectObjectHasProjectEdgeType::EDGECONST, +); foreach (new LiskMigrationIterator($table) as $txn) { // ManiphestTransaction::TYPE_PROJECTS if ($txn->getTransactionType() == 'projects') { diff --git a/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php index 4a13c09a21..229218d3b7 100644 --- a/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php +++ b/src/applications/auth/management/PhabricatorAuthManagementTrustOAuthClientWorkflow.php @@ -18,7 +18,8 @@ final class PhabricatorAuthManagementTrustOAuthClientWorkflow 'name' => 'id', 'param' => 'id', 'help' => pht('The id of the OAuth client.'), - ),)); + ), + )); } public function execute(PhutilArgumentParser $args) { diff --git a/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php b/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php index beecf450be..344e4b8864 100644 --- a/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php +++ b/src/applications/auth/management/PhabricatorAuthManagementUntrustOAuthClientWorkflow.php @@ -18,7 +18,8 @@ final class PhabricatorAuthManagementUntrustOAuthClientWorkflow 'name' => 'id', 'param' => 'id', 'help' => pht('The id of the OAuth client.'), - ),)); + ), + )); } public function execute(PhutilArgumentParser $args) { diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index ae846f5dbc..10a4dd79ef 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -256,7 +256,8 @@ abstract class PhabricatorController extends AphrontController { if ($must_sign_docs) { $controller = new LegalpadDocumentSignController(); $this->getRequest()->setURIMap(array( - 'id' => head($must_sign_docs)->getID(),)); + 'id' => head($must_sign_docs)->getID(), + )); $this->setCurrentApplication($legalpad); return $this->delegateToController($controller); } else { diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php index a432269dfa..3cb70a4e06 100644 --- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php +++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php @@ -283,7 +283,8 @@ final class PhabricatorConduitAPIController pht( 'This request originates from outside of the Phabricator '. 'cluster address range. Requests signed with trusted '. - 'device keys must originate from within the cluster.'),); + 'device keys must originate from within the cluster.'), + ); } $user = PhabricatorUser::getOmnipotentUser(); @@ -384,7 +385,8 @@ final class PhabricatorConduitAPIController pht( 'This request originates from outside of the Phabricator '. 'cluster address range. Requests signed with cluster API '. - 'tokens must originate from within the cluster.'),); + 'tokens must originate from within the cluster.'), + ); } // Flag this as an intracluster request. diff --git a/src/applications/config/check/PhabricatorBinariesSetupCheck.php b/src/applications/config/check/PhabricatorBinariesSetupCheck.php index 87e2066a13..87887d4a96 100644 --- a/src/applications/config/check/PhabricatorBinariesSetupCheck.php +++ b/src/applications/config/check/PhabricatorBinariesSetupCheck.php @@ -107,20 +107,25 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck { case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: $minimum_version = '1.5'; $bad_versions = array( - '1.7.1' => pht('This version of Subversion has a bug where '. - '"svn diff -c N" does not work for files added '. - 'in rN (Subversion issue #2873), fixed in 1.7.2.'),); + '1.7.1' => pht( + 'This version of Subversion has a bug where `%s` does not work '. + 'for files added in rN (Subversion issue #2873), fixed in 1.7.2.', + 'svn diff -c N'), + ); list($err, $stdout, $stderr) = exec_manual('svn --version --quiet'); $version = trim($stdout); break; case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: $minimum_version = '1.9'; $bad_versions = array( - '2.1' => pht('This version of Mercurial returns a bad exit code '. - 'after a successful pull.'), - '2.2' => pht('This version of Mercurial has a significant memory '. - 'leak, fixed in 2.2.1. Pushing fails with this '. - 'version as well; see T3046#54922.'),); + '2.1' => pht( + 'This version of Mercurial returns a bad exit code '. + 'after a successful pull.'), + '2.2' => pht( + 'This version of Mercurial has a significant memory leak, fixed '. + 'in 2.2.1. Pushing fails with this version as well; see %s.', + 'T3046#54922'), + ); $version = PhabricatorRepositoryVersion::getMercurialVersion(); break; } diff --git a/src/applications/conpherence/__tests__/ConpherenceTestCase.php b/src/applications/conpherence/__tests__/ConpherenceTestCase.php index ff7ddd5e5b..4528251100 100644 --- a/src/applications/conpherence/__tests__/ConpherenceTestCase.php +++ b/src/applications/conpherence/__tests__/ConpherenceTestCase.php @@ -9,7 +9,8 @@ abstract class ConpherenceTestCase extends PhabricatorTestCase { $xactions = array(id(new ConpherenceTransaction()) ->setTransactionType(ConpherenceTransactionType::TYPE_PARTICIPANTS) - ->setNewValue(array('+' => $participant_phids)),); + ->setNewValue(array('+' => $participant_phids)), + ); $editor = id(new ConpherenceEditor()) ->setActor($actor) ->setContentSource(PhabricatorContentSource::newConsoleSource()) @@ -24,7 +25,8 @@ abstract class ConpherenceTestCase extends PhabricatorTestCase { $xactions = array(id(new ConpherenceTransaction()) ->setTransactionType(ConpherenceTransactionType::TYPE_PARTICIPANTS) - ->setNewValue(array('-' => $participant_phids)),); + ->setNewValue(array('-' => $participant_phids)), + ); $editor = id(new ConpherenceEditor()) ->setActor($actor) ->setContentSource(PhabricatorContentSource::newConsoleSource()) diff --git a/src/applications/conpherence/controller/ConpherenceListController.php b/src/applications/conpherence/controller/ConpherenceListController.php index 38190367a9..899c3af3f6 100644 --- a/src/applications/conpherence/controller/ConpherenceListController.php +++ b/src/applications/conpherence/controller/ConpherenceListController.php @@ -125,7 +125,8 @@ final class ConpherenceListController extends ConpherenceController { ->execute(); return array( - 'all_participation' => $all_participation,); + 'all_participation' => $all_participation, + ); } private function loadConpherenceThreadData($participation) { diff --git a/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php b/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php index de7d6624e4..636504639e 100644 --- a/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php +++ b/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php @@ -178,7 +178,8 @@ final class ConpherenceThreadSearchEngine return array( 'rooms' => pht('Rooms'), 'messages' => pht('Messages'), - 'both' => pht('Both'),); + 'both' => pht('Both'), + ); } } diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php index 81f153038d..6c46bb760b 100644 --- a/src/applications/conpherence/storage/ConpherenceThread.php +++ b/src/applications/conpherence/storage/ConpherenceThread.php @@ -60,7 +60,8 @@ final class ConpherenceThread extends ConpherenceDAO ), self::CONFIG_KEY_SCHEMA => array( 'key_room' => array( - 'columns' => array('isRoom', 'dateModified'),), + 'columns' => array('isRoom', 'dateModified'), + ), 'key_phid' => null, 'phid' => array( 'columns' => array('phid'), diff --git a/src/applications/conpherence/view/ConpherenceDurableColumnView.php b/src/applications/conpherence/view/ConpherenceDurableColumnView.php index fd0cba5c0d..fc3a16d798 100644 --- a/src/applications/conpherence/view/ConpherenceDurableColumnView.php +++ b/src/applications/conpherence/view/ConpherenceDurableColumnView.php @@ -375,8 +375,8 @@ final class ConpherenceDurableColumnView extends AphrontTagView { ), $header), $settings_button, - $settings_menu,)); - + $settings_menu, + )); } private function getHeaderActionsConfig(ConpherenceThread $conpherence) { @@ -418,7 +418,8 @@ final class ConpherenceDurableColumnView extends AphrontTagView { 'href' => '#', 'icon' => 'fa-times', 'key' => 'hide_column', - ),); + ), + ); } private function buildTransactions() { @@ -441,7 +442,8 @@ final class ConpherenceDurableColumnView extends AphrontTagView { 'class' => 'button grey', 'sigil' => 'workflow', ), - pht('Send a Message')),); + pht('Send a Message')), + ); } $data = ConpherenceTransactionView::renderTransactions( @@ -501,7 +503,8 @@ final class ConpherenceDurableColumnView extends AphrontTagView { 'type' => 'hidden', 'name' => 'action', 'value' => ConpherenceUpdateActions::MESSAGE, - )),)); + )), + )); } private function buildStatusText() { diff --git a/src/applications/differential/application/PhabricatorDifferentialApplication.php b/src/applications/differential/application/PhabricatorDifferentialApplication.php index f9528c3d11..b866dda790 100644 --- a/src/applications/differential/application/PhabricatorDifferentialApplication.php +++ b/src/applications/differential/application/PhabricatorDifferentialApplication.php @@ -179,7 +179,8 @@ EOTEXT phutil_tag( 'a', array( - 'href' => $this->getInboundEmailSupportLink(),), + 'href' => $this->getInboundEmailSupportLink(), + ), pht('Learn More'))); } diff --git a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php index 1d6b461e0a..232fd71d59 100644 --- a/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php @@ -163,11 +163,13 @@ final class DifferentialCreateDiffConduitAPIMethod $request->getValue('sourceControlBaseRevision'), 'arcanistProjectPHID' => $project_phid, 'lintStatus' => $lint_status, - 'unitStatus' => $unit_status,); + 'unitStatus' => $unit_status, + ); $xactions = array(id(new DifferentialTransaction()) ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE) - ->setNewValue($diff_data_dict),); + ->setNewValue($diff_data_dict), + ); id(new DifferentialDiffEditor()) ->setActor($viewer) diff --git a/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php index 52999ad505..c7596fa04b 100644 --- a/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php @@ -53,11 +53,13 @@ final class DifferentialCreateRawDiffConduitAPIMethod 'authorPHID' => $viewer->getPHID(), 'repositoryPHID' => $repository_phid, 'lintStatus' => DifferentialLintStatus::LINT_SKIP, - 'unitStatus' => DifferentialUnitStatus::UNIT_SKIP,); + 'unitStatus' => DifferentialUnitStatus::UNIT_SKIP, + ); $xactions = array(id(new DifferentialTransaction()) ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE) - ->setNewValue($diff_data_dict),); + ->setNewValue($diff_data_dict), + ); if ($request->getValue('viewPolicy')) { $xactions[] = id(new DifferentialTransaction()) diff --git a/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php b/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php index 8b02ff2382..0f797d94d3 100644 --- a/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php +++ b/src/applications/differential/controller/DifferentialRevisionCloseDetailsController.php @@ -62,7 +62,8 @@ final class DifferentialRevisionCloseDetailsController phutil_tag( 'a', array( - 'href' => $obj_handle->getURI(),), + 'href' => $obj_handle->getURI(), + ), $obj_handle->getName())); } else if ($revision_match_data['foundURI']) { $body_why[] = pht( @@ -96,7 +97,8 @@ final class DifferentialRevisionCloseDetailsController $diff_link = phutil_tag( 'a', array( - 'href' => $obj_handle->getURI(),), + 'href' => $obj_handle->getURI(), + ), $obj_handle->getName()); $body_why = pht( 'This commit and the active diff of %s had the same %s hash '. diff --git a/src/applications/differential/mail/DifferentialCreateMailReceiver.php b/src/applications/differential/mail/DifferentialCreateMailReceiver.php index 614c52306d..d54faffc40 100644 --- a/src/applications/differential/mail/DifferentialCreateMailReceiver.php +++ b/src/applications/differential/mail/DifferentialCreateMailReceiver.php @@ -59,7 +59,8 @@ final class DifferentialCreateMailReceiver extends PhabricatorMailReceiver { $call = new ConduitCall( 'differential.createrawdiff', array( - 'diff' => $body,)); + 'diff' => $body, + )); $call->setUser($sender); try { $result = $call->execute(); diff --git a/src/applications/files/application/PhabricatorFilesApplication.php b/src/applications/files/application/PhabricatorFilesApplication.php index 9083201ac1..1187b0545b 100644 --- a/src/applications/files/application/PhabricatorFilesApplication.php +++ b/src/applications/files/application/PhabricatorFilesApplication.php @@ -51,7 +51,8 @@ final class PhabricatorFilesApplication extends PhabricatorApplication { phutil_tag( 'a', array( - 'href' => $this->getInboundEmailSupportLink(),), + 'href' => $this->getInboundEmailSupportLink(), + ), pht('Learn More'))); } diff --git a/src/applications/maniphest/application/PhabricatorManiphestApplication.php b/src/applications/maniphest/application/PhabricatorManiphestApplication.php index 07fbc0d1c9..cbdd4a79e6 100644 --- a/src/applications/maniphest/application/PhabricatorManiphestApplication.php +++ b/src/applications/maniphest/application/PhabricatorManiphestApplication.php @@ -122,7 +122,8 @@ final class PhabricatorManiphestApplication extends PhabricatorApplication { phutil_tag( 'a', array( - 'href' => $this->getInboundEmailSupportLink(),), + 'href' => $this->getInboundEmailSupportLink(), + ), pht('Learn More'))); } diff --git a/src/applications/paste/application/PhabricatorPasteApplication.php b/src/applications/paste/application/PhabricatorPasteApplication.php index a970a889c3..c0afe865bf 100644 --- a/src/applications/paste/application/PhabricatorPasteApplication.php +++ b/src/applications/paste/application/PhabricatorPasteApplication.php @@ -55,7 +55,8 @@ final class PhabricatorPasteApplication extends PhabricatorApplication { phutil_tag( 'a', array( - 'href' => $this->getInboundEmailSupportLink(),), + 'href' => $this->getInboundEmailSupportLink(), + ), pht('Learn More'))); } diff --git a/src/applications/phriction/controller/PhrictionDocumentController.php b/src/applications/phriction/controller/PhrictionDocumentController.php index f26e807d03..a00f7816a5 100644 --- a/src/applications/phriction/controller/PhrictionDocumentController.php +++ b/src/applications/phriction/controller/PhrictionDocumentController.php @@ -376,7 +376,8 @@ final class PhrictionDocumentController $child_dict = array( 'slug' => $child->getSlug(), 'depth' => $child->getDepth(), - 'title' => $child->getContent()->getTitle(),); + 'title' => $child->getContent()->getTitle(), + ); if ($child->getDepth() == $d_child) { $children_dicts[] = $child_dict; continue; diff --git a/src/applications/phriction/editor/PhrictionTransactionEditor.php b/src/applications/phriction/editor/PhrictionTransactionEditor.php index 44a2436bf6..0df10ffb8c 100644 --- a/src/applications/phriction/editor/PhrictionTransactionEditor.php +++ b/src/applications/phriction/editor/PhrictionTransactionEditor.php @@ -132,7 +132,8 @@ final class PhrictionTransactionEditor 'id' => $document->getID(), 'phid' => $document->getPHID(), 'content' => $document->getContent()->getContent(), - 'title' => $document->getContent()->getTitle(),); + 'title' => $document->getContent()->getTitle(), + ); return $dict; case PhrictionTransaction::TYPE_MOVE_AWAY: $document = $xaction->getNewValue(); @@ -140,7 +141,8 @@ final class PhrictionTransactionEditor 'id' => $document->getID(), 'phid' => $document->getPHID(), 'content' => $document->getContent()->getContent(), - 'title' => $document->getContent()->getTitle(),); + 'title' => $document->getContent()->getTitle(), + ); return $dict; } } diff --git a/src/applications/policy/config/PhabricatorPolicyConfigOptions.php b/src/applications/policy/config/PhabricatorPolicyConfigOptions.php index d629b5b370..2b47ae8d80 100644 --- a/src/applications/policy/config/PhabricatorPolicyConfigOptions.php +++ b/src/applications/policy/config/PhabricatorPolicyConfigOptions.php @@ -22,7 +22,8 @@ final class PhabricatorPolicyConfigOptions public function getOptions() { $policy_locked_type = 'custom:PolicyLockOptionType'; $policy_locked_example = array( - 'people.create.users' => 'admin',); + 'people.create.users' => 'admin', + ); $json = new PhutilJSON(); $policy_locked_example = $json->encodeFormatted($policy_locked_example); diff --git a/src/applications/transactions/controller/PhabricatorApplicationTransactionShowOlderController.php b/src/applications/transactions/controller/PhabricatorApplicationTransactionShowOlderController.php index e21ef0e075..bd8a834d40 100644 --- a/src/applications/transactions/controller/PhabricatorApplicationTransactionShowOlderController.php +++ b/src/applications/transactions/controller/PhabricatorApplicationTransactionShowOlderController.php @@ -49,7 +49,8 @@ final class PhabricatorApplicationTransactionShowOlderController return id(new AphrontAjaxResponse()) ->setContent(array( - 'timeline' => hsprintf('%s', $events),)); + 'timeline' => hsprintf('%s', $events), + )); } } diff --git a/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php b/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php index 9ec86c5305..0d39eb62c6 100644 --- a/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php +++ b/src/infrastructure/diff/view/PhabricatorInlineSummaryView.php @@ -39,7 +39,8 @@ final class PhabricatorInlineSummaryView extends AphrontView { ), array( $icon, - $group,)); + $group, + )); $rows[] = phutil_tag('tr', array(), $header); foreach ($items as $item) { diff --git a/src/view/control/AphrontTableView.php b/src/view/control/AphrontTableView.php index d20ae1887f..a9ce74eac0 100644 --- a/src/view/control/AphrontTableView.php +++ b/src/view/control/AphrontTableView.php @@ -305,7 +305,8 @@ final class AphrontTableView extends AphrontView { $html = phutil_tag( 'table', array( - 'class' => implode(' ', $classes),), + 'class' => implode(' ', $classes), + ), $table); return phutil_tag_div('aphront-table-wrap', $html); } diff --git a/src/view/form/control/AphrontFormControl.php b/src/view/form/control/AphrontFormControl.php index f2be0764b6..4118d9ad4e 100644 --- a/src/view/form/control/AphrontFormControl.php +++ b/src/view/form/control/AphrontFormControl.php @@ -212,7 +212,8 @@ abstract class AphrontFormControl extends AphrontView { ), array( $this->getLabel(), - $error,)); + $error, + )); } else { $label = null; $custom_class .= ' aphront-form-control-nolabel'; diff --git a/src/view/layout/PhabricatorTransactionView.php b/src/view/layout/PhabricatorTransactionView.php index 0b10463600..9b3b4bbf49 100644 --- a/src/view/layout/PhabricatorTransactionView.php +++ b/src/view/layout/PhabricatorTransactionView.php @@ -81,7 +81,8 @@ final class PhabricatorTransactionView extends AphrontView { array( $image, phutil_tag_div('phabricator-transaction-detail grouped', - array($header, $content)),)); + array($header, $content)), + )); } @@ -129,7 +130,8 @@ final class PhabricatorTransactionView extends AphrontView { return phutil_tag( 'span', array( - 'class' => 'phabricator-transaction-info',), + 'class' => 'phabricator-transaction-info', + ), $info); } diff --git a/src/view/phui/PHUIDocumentView.php b/src/view/phui/PHUIDocumentView.php index 3d7e645309..833bb48fe5 100644 --- a/src/view/phui/PHUIDocumentView.php +++ b/src/view/phui/PHUIDocumentView.php @@ -174,7 +174,8 @@ final class PHUIDocumentView extends AphrontTagView { 'map' => array( $this->actionListID => 'phabricator-action-list-toggle', $icon_id => 'phuix-dropdown-open', - ),); + ), + ); $mobile_menu = id(new PHUIButtonView()) ->setTag('a') ->setText(pht('Actions')) diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php index a282d928b3..b319d4d5d5 100644 --- a/src/view/phui/PHUIObjectBoxView.php +++ b/src/view/phui/PHUIObjectBoxView.php @@ -171,7 +171,8 @@ final class PHUIObjectBoxView extends AphrontView { 'map' => array( $this->actionListID => 'phabricator-action-list-toggle', $icon_id => 'phuix-dropdown-open', - ),); + ), + ); $mobile_menu = id(new PHUIButtonView()) ->setTag('a') ->setText(pht('Actions')) diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php index 36cf231d88..5516a4a763 100644 --- a/src/view/phui/PHUIObjectItemView.php +++ b/src/view/phui/PHUIObjectItemView.php @@ -581,7 +581,8 @@ final class PHUIObjectItemView extends AphrontTagView { ), array( $icons, - $bylines,)); + $bylines, + )); } $table = phutil_tag( diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php index 41c02aa6e9..bc14f5776b 100644 --- a/src/view/phui/PHUITimelineEventView.php +++ b/src/view/phui/PHUITimelineEventView.php @@ -435,7 +435,8 @@ final class PHUITimelineEventView extends AphrontView { 'class' => 'phui-timeline-event-view '. 'phui-timeline-spacer '. 'phui-timeline-spacer-bold', - '',)); + '', + )); } return array( @@ -453,7 +454,8 @@ final class PHUITimelineEventView extends AphrontView { 'class' => implode(' ', $classes), ), $content)), - $major_event,); + $major_event, + ); } private function renderExtra(array $events) {