minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Improve exception when creating a cyclic dependency in Maniphest

Browse source 
Summary: Fixes T6815. This was overlooked in D9838. This could be prettier, but does the job.

Test Plan: {F327790}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6815

Differential Revision: https://secure.phabricator.com/D11937
This commit is contained in:
epriestley 2015-03-02 16:36:44 -08:00
parent e5e3eb357f
commit e651169879
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/search/controller/PhabricatorSearchAttachController.php
View file

@ -84,9 +84,14 @@ final class PhabricatorSearchAttachController
'+' => array_fuse($add_phids), '+' => array_fuse($add_phids),
'-' => array_fuse($rem_phids), '-' => array_fuse($rem_phids),
)); ));
$txn_editor->applyTransactions(
$object->getApplicationTransactionObject(), try {
array($txn_template)); $txn_editor->applyTransactions(
$object->getApplicationTransactionObject(),
array($txn_template));
} catch (PhabricatorEdgeCycleException $ex) {
$this->raiseGraphCycleException($ex);
}
return id(new AphrontReloadResponse())->setURI($handle->getURI()); return id(new AphrontReloadResponse())->setURI($handle->getURI());
} else { } else {