minsoochoo/phorge
minsoochoo/phorge
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Remove IE6/7 non-standard "_zoom" CSS workaround

Browse source 
Summary:
Phorge does not support these browser versions anymore.

Quoting https://css-tricks.com/almanac/properties/z/zoom/: "Many of the rendering bugs in both IE6 and IE7 could be fixed using zoom. [...] Setting zoom: 1 turned on an internal property called hasLayout, which fixed the problem."
See also https://web.archive.org/web/20150906195720/https://developer.mozilla.org/en-US/docs/Web/CSS/zoom

And while `zoom` is recently seeing standardization per https://developer.mozilla.org/en-US/docs/Web/CSS/zoom there still wouldn't be an underscore prefix character.

Test Plan:
Walk up to the library and dive into some dusty books about the wild early days of CSS.

Also, enjoy the conversation about that line using git blame:

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;0aa67025f25d30162309d59b4cbe133b6180b2d7$7 - 2011

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;7a9d5f8f2de5e44f4014116a47de4ea870361732$7 - 2013

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;3cf6f746f0555b4d73d587972d896de99667fb06$7 - 2014

https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/aphront/typeahead.css;7aee92b5e95cfc11059e9ff8788e5e53dc88e84d$7 - 2017

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25974
This commit is contained in:
Andre Klapper 2025-04-25 13:26:19 +02:00
parent 4bd591e441
commit dfe8539c6a
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array(
'conpherence.pkg.css' => '3144a5e2',
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '8aed2c92',
'core.pkg.css' => '3406c4ea',
'core.pkg.js' => '086da722',
'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => '91ac6214',
@ -35,7 +35,7 @@ return array(
'rsrc/css/aphront/tokenizer.css' => '194e8160',
'rsrc/css/aphront/tooltip.css' => 'e3f2412f',
'rsrc/css/aphront/typeahead-browse.css' => 'b7ed02d2',
'rsrc/css/aphront/typeahead.css' => '8779483d',
'rsrc/css/aphront/typeahead.css' => '5da109c8',
'rsrc/css/application/almanac/almanac.css' => '2e050f4f',
'rsrc/css/application/auth/auth.css' => 'c2f23d74',
'rsrc/css/application/base/main-menu-view.css' => '741a6bba',
@ -542,7 +542,7 @@ return array(
'aphront-table-view-css' => '0bb61df1',
'aphront-tokenizer-control-css' => '194e8160',
'aphront-tooltip-css' => 'e3f2412f',
'aphront-typeahead-control-css' => '8779483d',
'aphront-typeahead-control-css' => '5da109c8',
'application-search-view-css' => '0f7c06d8',
'auth-css' => 'c2f23d74',
'bulk-job-css' => '73af99f5',

1
webroot/rsrc/css/aphront/typeahead.css
View file

@ -4,7 +4,6 @@
div.jx-typeahead-hardpoint {
position: relative;
_zoom: 1; /* Some kind of IE6 fix? */ /* yes */ /* why? */ /* still need? */
}
div.jx-typeahead-results {