From df67401e24bb2aeedea9a5a2bd09db7a8ca67d20 Mon Sep 17 00:00:00 2001 From: vrana Date: Sat, 7 Apr 2012 12:01:25 -0700 Subject: [PATCH] Add typehints to Diffusion browse file controller Test Plan: Display commit. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2139 --- .../file/DiffusionBrowseFileController.php | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php index 187cd280eb..f52a252cbe 100644 --- a/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php +++ b/src/applications/diffusion/controller/file/DiffusionBrowseFileController.php @@ -80,9 +80,9 @@ final class DiffusionBrowseFileController extends DiffusionController { } private function buildCorpus($selected, - $file_query, + DiffusionFileContentQuery $file_query, $needs_blame, - $drequest, + DiffusionRequest $drequest, $path, $data) { @@ -236,8 +236,15 @@ final class DiffusionBrowseFileController extends DiffusionController { 'Edit'); } - private function buildDisplayRows($text_list, $rev_list, $blame_dict, - $needs_blame, DiffusionRequest $drequest, $file_query, $selected) { + private function buildDisplayRows( + array $text_list, + array $rev_list, + array $blame_dict, + $needs_blame, + DiffusionRequest $drequest, + DiffusionFileContentQuery $file_query, + $selected) { + $last_rev = null; $color = '#eeeeee'; $rows = array();