Minor, make sure we release locks in pull daemon if we fail in unusual ways
Summary: A user is reporting a re-lock in this daemon, which I can't reproduce, but might be possible if this throws. Stop it from throwing in a way which evades unlock. See: <https://github.com/facebook/phabricator/issues/476> Auditors: btrahan
This commit is contained in:
parent
54a0dd8139
commit
d9a04fcb53
|
@ -144,11 +144,10 @@ final class PhabricatorRepositoryPullLocalDaemon
|
|||
$lock = PhabricatorGlobalLock::newLock($lock_name);
|
||||
$lock->lock();
|
||||
|
||||
$repository->writeStatusMessage(
|
||||
PhabricatorRepositoryStatusMessage::TYPE_NEEDS_UPDATE,
|
||||
null);
|
||||
|
||||
try {
|
||||
$repository->writeStatusMessage(
|
||||
PhabricatorRepositoryStatusMessage::TYPE_NEEDS_UPDATE,
|
||||
null);
|
||||
$this->discoverRepository($repository);
|
||||
$repository->writeStatusMessage(
|
||||
PhabricatorRepositoryStatusMessage::TYPE_FETCH,
|
||||
|
|
Loading…
Reference in a new issue