From d243c3019015147647fdce75b101e60f36b19109 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 20 Aug 2013 09:48:31 -0700 Subject: [PATCH] Remove ReleephRequestException Summary: This has two use sites and no special logic. Test Plan: `grep` Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6783 --- src/__phutil_library_map__.php | 2 -- .../request/ReleephRequestDifferentialCreateController.php | 4 ++-- .../storage/request/exception/ReleephRequestException.php | 3 --- 3 files changed, 2 insertions(+), 7 deletions(-) delete mode 100644 src/applications/releeph/storage/request/exception/ReleephRequestException.php diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index e96887bd12..de7cbcd5ef 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -1986,7 +1986,6 @@ phutil_register_library_map(array( 'ReleephRequestCommentController' => 'applications/releeph/controller/request/ReleephRequestCommentController.php', 'ReleephRequestDifferentialCreateController' => 'applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php', 'ReleephRequestEditController' => 'applications/releeph/controller/request/ReleephRequestEditController.php', - 'ReleephRequestException' => 'applications/releeph/storage/request/exception/ReleephRequestException.php', 'ReleephRequestHeaderListView' => 'applications/releeph/view/request/header/ReleephRequestHeaderListView.php', 'ReleephRequestHeaderView' => 'applications/releeph/view/request/header/ReleephRequestHeaderView.php', 'ReleephRequestIntentsView' => 'applications/releeph/view/request/ReleephRequestIntentsView.php', @@ -4187,7 +4186,6 @@ phutil_register_library_map(array( 'ReleephRequestCommentController' => 'ReleephProjectController', 'ReleephRequestDifferentialCreateController' => 'ReleephProjectController', 'ReleephRequestEditController' => 'ReleephProjectController', - 'ReleephRequestException' => 'Exception', 'ReleephRequestHeaderListView' => 'AphrontView', 'ReleephRequestHeaderView' => 'AphrontView', 'ReleephRequestIntentsView' => 'AphrontView', diff --git a/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php b/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php index 990dbb60e6..283924599a 100644 --- a/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php +++ b/src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php @@ -25,7 +25,7 @@ final class ReleephRequestDifferentialCreateController 'arcanistProjectID = %d AND isActive = 1', $arc_project->getID()); if (!$projects) { - throw new ReleephRequestException(sprintf( + throw new Exception(sprintf( "D%d belongs to the '%s' Arcanist project, ". "which is not part of any Releeph project!", $this->revision->getID(), @@ -36,7 +36,7 @@ final class ReleephRequestDifferentialCreateController 'releephProjectID IN (%Ld) AND isActive = 1', mpull($projects, 'getID')); if (!$branches) { - throw new ReleephRequestException(sprintf( + throw new Exception(sprintf( "D%d could be in the Releeph project(s) %s, ". "but this project / none of these projects have open branches.", $this->revision->getID(), diff --git a/src/applications/releeph/storage/request/exception/ReleephRequestException.php b/src/applications/releeph/storage/request/exception/ReleephRequestException.php deleted file mode 100644 index 6f22f8c29a..0000000000 --- a/src/applications/releeph/storage/request/exception/ReleephRequestException.php +++ /dev/null @@ -1,3 +0,0 @@ -