diff --git a/src/applications/differential/engine/DifferentialDiffExtractionEngine.php b/src/applications/differential/engine/DifferentialDiffExtractionEngine.php index 7b94b1958b..08e0a344e0 100644 --- a/src/applications/differential/engine/DifferentialDiffExtractionEngine.php +++ b/src/applications/differential/engine/DifferentialDiffExtractionEngine.php @@ -243,8 +243,6 @@ final class DifferentialDiffExtractionEngine extends Phobject { PhabricatorContentSource $content_source) { $viewer = $this->getViewer(); - $result_data = array(); - $new_diff = $this->newDiffFromCommit($commit); $old_diff = $revision->getActiveDiff(); @@ -261,8 +259,6 @@ final class DifferentialDiffExtractionEngine extends Phobject { $old_diff, $new_diff); if ($has_changed) { - $result_data['vsDiff'] = $old_diff->getID(); - $revision_monogram = $revision->getMonogram(); $old_id = $old_diff->getID(); $new_id = $new_diff->getID(); @@ -336,8 +332,6 @@ final class DifferentialDiffExtractionEngine extends Phobject { // lost a race to close the revision. That's perfectly fine, we can // just continue normally. } - - return $result_data; } private function loadConcerningBuilds(DifferentialRevision $revision) { diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php index 8a1b5e5dd1..b0583725a9 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php @@ -278,17 +278,13 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker $content_source = $this->newContentSource(); - $update_data = $extraction_engine->updateRevisionWithCommit( + $extraction_engine->updateRevisionWithCommit( $revision, $commit, array( $commit_close_xaction, ), $content_source); - - foreach ($update_data as $key => $value) { - $data->setCommitDetail($key, $value); - } } } }