diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index 1e69e5661a..c856436fd8 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -72,7 +72,7 @@ final class DifferentialRevision extends DifferentialDAO ->attachRepository(null) ->attachActiveDiff(null) ->attachReviewers(array()) - ->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW); + ->setModernRevisionStatus(DifferentialRevisionStatus::NEEDS_REVIEW); } protected function getConfiguration() { diff --git a/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php b/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php index 2f221bd8c6..b7b0e7f123 100644 --- a/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php @@ -47,7 +47,8 @@ final class DifferentialRevisionAbandonTransaction } public function applyInternalEffects($object, $value) { - $object->setStatus(ArcanistDifferentialRevisionStatus::ABANDONED); + $status_abandoned = DifferentialRevisionStatus::ABANDONED; + $object->setModernRevisionStatus($status_abandoned); } protected function validateAction($object, PhabricatorUser $viewer) { diff --git a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php index 203b84a191..8d01f48eff 100644 --- a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php @@ -37,8 +37,8 @@ final class DifferentialRevisionCloseTransaction public function applyInternalEffects($object, $value) { $was_accepted = $object->isAccepted(); - $status_closed = ArcanistDifferentialRevisionStatus::CLOSED; - $object->setStatus($status_closed); + $status_published = DifferentialRevisionStatus::PUBLISHED; + $object->setModernRevisionStatus($status_published); $object->setProperty( DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED, diff --git a/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php b/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php index 043071dc96..6e584ceb36 100644 --- a/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php @@ -50,8 +50,8 @@ final class DifferentialRevisionPlanChangesTransaction } public function applyInternalEffects($object, $value) { - $status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED; - $object->setStatus($status_planned); + $status_planned = DifferentialRevisionStatus::CHANGES_PLANNED; + $object->setModernRevisionStatus($status_planned); } protected function validateAction($object, PhabricatorUser $viewer) { diff --git a/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php index 1f2f6a8d6c..4767924445 100644 --- a/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php @@ -47,7 +47,8 @@ final class DifferentialRevisionReclaimTransaction } public function applyInternalEffects($object, $value) { - $object->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW); + $status_review = DifferentialRevisionStatus::NEEDS_REVIEW; + $object->setModernRevisionStatus($status_review); } protected function validateAction($object, PhabricatorUser $viewer) { diff --git a/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php index 7ba20772c7..1d28433429 100644 --- a/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php @@ -35,7 +35,8 @@ final class DifferentialRevisionReopenTransaction } public function applyInternalEffects($object, $value) { - $object->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW); + $status_review = DifferentialRevisionStatus::NEEDS_REVIEW; + $object->setModernRevisionStatus($status_review); } protected function validateAction($object, PhabricatorUser $viewer) { diff --git a/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php b/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php index 2dae24b6fa..d102b0c0c2 100644 --- a/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php @@ -31,8 +31,8 @@ final class DifferentialRevisionRequestReviewTransaction } public function applyInternalEffects($object, $value) { - $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW; - $object->setStatus($status_review); + $status_review = DifferentialRevisionStatus::NEEDS_REVIEW; + $object->setModernRevisionStatus($status_review); } protected function validateAction($object, PhabricatorUser $viewer) {