[FreeBSD] tweaks to account approval flow

- use CC, not TO for awaiting approval
- don't show the approving admin in the accepted email
- use "FreeBSD" as a title

src/applications/auth/controller/PhabricatorAuthRegisterController.php

@@ -772,7 +772,7 @@ final class PhabricatorAuthRegisterController
     }
 
     $mail = id(new PhabricatorMetaMTAMail())
-      ->addTos(mpull($admins, 'getPHID'))
+      ->addCCs(mpull($admins, 'getPHID'))
       ->setSubject($title)
       ->setBody($body->render())
       ->saveAndSend();

src/applications/people/xaction/PhabricatorUserApproveTransaction.php

@@ -29,21 +29,15 @@ final class PhabricatorUserApproveTransaction
     $body = sprintf(
       "%s\n\n  %s\n\n",
       pht(
-        'Your %s account (%s) has been approved by %s. You can '.
+        'Your Phabricator account (%s) has been approved. You can '.
         'login here:',
         PlatformSymbols::getPlatformServerName(),
-        $user->getUsername(),
+        $user->getUsername()),
-        $actor->getUsername()),
       PhabricatorEnv::getProductionURI('/'));
 
     $mail = id(new PhabricatorMetaMTAMail())
       ->addTos(array($user->getPHID()))
-      ->addCCs(array($actor->getPHID()))
+      ->setSubject('[FreeBSD] '.$title)
-      ->setSubject(
-        pht(
-          '[%s] %s',
-          PlatformSymbols::getPlatformServerName(),
-          $title))
       ->setForceDelivery(true)
       ->setBody($body)
       ->saveAndSend();