From c0191a039293b6585bd6a2db0a8b47e82a7a9bc2 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Fri, 26 Jan 2024 19:12:21 +0100
Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception creating a Merchant in
 Phortune

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/phortune/provider/PhortunePaymentProvider.php:99]
```

Closes T15725

Test Plan: See steps in T15725

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15725

Differential Revision: https://we.phorge.it/D25528
---
 src/applications/phortune/provider/PhortunePaymentProvider.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/phortune/provider/PhortunePaymentProvider.php b/src/applications/phortune/provider/PhortunePaymentProvider.php
index 57b2956ecb..eb6d2ff2e3 100644
--- a/src/applications/phortune/provider/PhortunePaymentProvider.php
+++ b/src/applications/phortune/provider/PhortunePaymentProvider.php
@@ -96,7 +96,7 @@ abstract class PhortunePaymentProvider extends Phobject {
     array $issues);
 
   protected function renderConfigurationSecret($value) {
-    if (strlen($value)) {
+    if (phutil_nonempty_string($value)) {
       return str_repeat('*', strlen($value));
     }
     return '';