From bfb9451f147b1c99676a0dba1ebf483d77b47e00 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Thu, 8 May 2025 15:49:48 +0200 Subject: [PATCH] Remove orphan CSS selectors in calendar/phui-calendar.css Summary: * `phui-calendar-bg-blue` * `phui-calendar-bg-green` * `phui-calendar-bg-grey` * `phui-calendar-bg-indigo` * `phui-calendar-bg-orange` * `phui-calendar-bg-red` * `phui-calendar-bg-sky` * `phui-calendar-bg-viewer-invited` * `phui-calendar-bg-violet` * `phui-calendar-bg-yellow` * `phui-calendar-blue` * `phui-calendar-green` * `phui-calendar-grey` * `phui-calendar-indigo` * `phui-calendar-orange` * `phui-calendar-red` * `phui-calendar-sky` * `phui-calendar-violet` * `phui-calendar-yellow` * `phui-calendar-event-empty` * `phui-calendar-list-dot` * `phui-calendar-viewer-invited` ** Added in https://we.phorge.it/rP396e8ba82c221c085d17f1574551fbff42459452, usage removed in https://we.phorge.it/rP4016107411c12d8658a2cfeefeef19b7c12fa6cb (`$class = 'phui-calendar-list-item phui-calendar-'.$color;`) resp. https://we.phorge.it/rPb6c3d184d200e6bc43ba8f15a069c3a8620779cc from `src/view/phui/calendar/PHUICalendarListView.php` Test Plan: Grep the code for each CSS selector (`grep --exclude="*.css" -R 'some-search-string' .`), also do partial searches, get no results. Optionally, play with calendar list view. Create events in which you are: - Busy - Available - Away - Invited - Invited and Confirmed No visible color regressions. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26000 --- resources/celerity/map.php | 4 +- .../rsrc/css/phui/calendar/phui-calendar.css | 135 ------------------ 2 files changed, 2 insertions(+), 137 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 7f1f281fe6..caaee71c05 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -122,7 +122,7 @@ return array( 'rsrc/css/phui/calendar/phui-calendar-day.css' => '9597d706', 'rsrc/css/phui/calendar/phui-calendar-list.css' => 'ccd7e4e2', 'rsrc/css/phui/calendar/phui-calendar-month.css' => 'cb758c42', - 'rsrc/css/phui/calendar/phui-calendar.css' => 'f11073aa', + 'rsrc/css/phui/calendar/phui-calendar.css' => '5dfee96b', 'rsrc/css/phui/object-item/phui-oi-big-ui.css' => 'fa74cc35', 'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0', 'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc', @@ -805,7 +805,7 @@ return array( 'phui-button-bar-css' => 'a4aa75c4', 'phui-button-css' => '66c38b9a', 'phui-button-simple-css' => '1ff278aa', - 'phui-calendar-css' => 'f11073aa', + 'phui-calendar-css' => '5dfee96b', 'phui-calendar-day-css' => '9597d706', 'phui-calendar-list-css' => 'ccd7e4e2', 'phui-calendar-month-css' => 'cb758c42', diff --git a/webroot/rsrc/css/phui/calendar/phui-calendar.css b/webroot/rsrc/css/phui/calendar/phui-calendar.css index 0d8dcfc56e..500226997a 100644 --- a/webroot/rsrc/css/phui/calendar/phui-calendar.css +++ b/webroot/rsrc/css/phui/calendar/phui-calendar.css @@ -22,138 +22,3 @@ .phui-calendar-list .event-cancelled .phui-calendar-list-title { text-decoration: line-through; } - -.phui-calendar-viewer-invited a { - color: {$green}; -} - -.phui-calendar-red a { - color: {$red}; -} - -.phui-calendar-orange a { - color: {$orange}; -} - -.phui-calendar-yellow a { - color: {$yellow}; -} - -.phui-calendar-green a { - color: {$green} -} - -.phui-calendar-blue a { - color: {$blue}; -} - -.phui-calendar-sky a { - color: {$sky}; -} - -.phui-calendar-indigo a { - color: {$indigo}; -} - -.phui-calendar-violet a { - color: {$violet}; -} - -.phui-calendar-grey a { - color: {$lightgreytext}; -} - -.phui-calendar-bg-viewer-invited { - background-color: {$lightgreen}; -} - -.phui-calendar-bg-red { - background-color: {$lightred}; -} - -.phui-calendar-bg-orange { - background-color: {$lightorange}; -} - -.phui-calendar-bg-yellow { - background-color: {$lightyellow}; -} - -.phui-calendar-bg-green { - background-color: {$lightgreen}; -} - -.phui-calendar-bg-blue { - background-color: {$lightblue}; -} - -.phui-calendar-bg-sky { - background-color: {$lightsky}; -} - -.phui-calendar-bg-indigo { - background-color: {$lightindigo}; -} - -.phui-calendar-bg-violet { - background-color: {$lightviolet}; -} - -.phui-calendar-bg-grey { - background-color: {$darkgreybackground}; -} - -.phui-calendar-list-dot { - background-color: {$lightgreytext}; - border-color: {$lightgreytext}; -} - -.phui-calendar-viewer-invited .phui-calendar-list-dot { - background-color: {$green}; - border-color: {$green}; -} - -.phui-calendar-red .phui-calendar-list-dot { - background-color: {$red}; - border-color: {$red}; -} - -.phui-calendar-orange .phui-calendar-list-dot { - background-color: {$orange}; - border-color: {$orange}; -} - -.phui-calendar-yellow .phui-calendar-list-dot { - background-color: {$orange}; - border-color: {$orange}; -} - -.phui-calendar-green .phui-calendar-list-dot { - background-color: {$green}; - border-color: {$green}; -} - -.phui-calendar-blue .phui-calendar-list-dot { - background-color: {$blue}; - border-color: {$blue}; -} - -.phui-calendar-sky .phui-calendar-list-dot { - background-color: {$sky}; - border-color: {$sky}; -} - -.phui-calendar-indigo .phui-calendar-list-dot { - background-color: {$indigo}; - border-color: {$indigo}; -} - -.phui-calendar-violet .phui-calendar-list-dot { - background-color: {$violet}; - border-color: {$violet}; -} - -.phui-calendar-grey .phui-calendar-list-dot { - background-color: {$lightgreytext}; - border-color: {$lightgreytext}; -}