From be586de965cfb42ac933c304c8ceb354fd9cdb28 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sun, 7 Apr 2013 15:50:21 -0700
Subject: [PATCH] Remove logic which hides commit names in commit table when
 they're the same as previous commit names

Summary:
See discussion in T2832. In particular, this is pretty confusing:

{F38674}

The confusion created in situations like this is much worse than the tiny benefit in parseability the UI rule provides. We'll probably rewrite this table in terms of ObjectListView anyway.

Fixes T2832.

Test Plan: Looked at Audit list.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2832

Differential Revision: https://secure.phabricator.com/D5610
---
 .../audit/view/PhabricatorAuditListView.php    | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php
index b79634e888..42487dae5b 100644
--- a/src/applications/audit/view/PhabricatorAuditListView.php
+++ b/src/applications/audit/view/PhabricatorAuditListView.php
@@ -110,22 +110,16 @@ final class PhabricatorAuditListView extends AphrontView {
   public function render() {
     $rowc = array();
 
-    $last = null;
     $rows = array();
     foreach ($this->audits as $audit) {
       $commit_phid = $audit->getCommitPHID();
       $committed = null;
-      if ($last == $commit_phid) {
-        $commit_name = null;
-        $commit_desc = null;
-      } else {
-        $commit_name = $this->getHandle($commit_phid)->renderLink();
-        $commit_desc = $this->getCommitDescription($commit_phid);
-        $commit = idx($this->commits, $commit_phid);
-        if ($commit && $this->user) {
-          $committed = phabricator_datetime($commit->getEpoch(), $this->user);
-        }
-        $last = $commit_phid;
+
+      $commit_name = $this->getHandle($commit_phid)->renderLink();
+      $commit_desc = $this->getCommitDescription($commit_phid);
+      $commit = idx($this->commits, $commit_phid);
+      if ($commit && $this->user) {
+        $committed = phabricator_datetime($commit->getEpoch(), $this->user);
       }
 
       $reasons = $audit->getAuditReasons();