From ba4b8cb1ae7d209caf6e2a209247e114262d0d15 Mon Sep 17 00:00:00 2001 From: Aviv Eyal Date: Fri, 18 Aug 2023 12:28:03 -0700 Subject: [PATCH] PHP 8 and Diviner Technical Documentation Summary: This also fixes the field Personal Settings > Display Preferences > Monospaced Font, when empty. Close T15621 Test Plan: Generate diviner stuff, navigate to the "Technical Documentation" section (In php 8.1+) Reviewers: O1 Blessed Committers, mturdus, valerio.bozzolan Reviewed By: O1 Blessed Committers, mturdus, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15621 Differential Revision: https://we.phorge.it/D25412 --- src/applications/diviner/storage/DivinerLiveSymbol.php | 2 +- .../settings/setting/PhabricatorMonospacedFontSetting.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/diviner/storage/DivinerLiveSymbol.php b/src/applications/diviner/storage/DivinerLiveSymbol.php index d62e6a1e18..6477e00879 100644 --- a/src/applications/diviner/storage/DivinerLiveSymbol.php +++ b/src/applications/diviner/storage/DivinerLiveSymbol.php @@ -172,7 +172,7 @@ final class DivinerLiveSymbol extends DivinerDAO public function getTitle() { $title = parent::getTitle(); - if (!strlen($title)) { + if (!phutil_nonempty_string($title)) { $title = $this->getName(); } diff --git a/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php b/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php index 2a96f5d95f..5cfbec1b26 100644 --- a/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php +++ b/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php @@ -25,7 +25,7 @@ final class PhabricatorMonospacedFontSetting } public function validateTransactionValue($value) { - if (!strlen($value)) { + if (!phutil_nonempty_string($value)) { return; }