From b6fa4856d2e2d2345a79ac723501a02df8cc4947 Mon Sep 17 00:00:00 2001 From: Michael Peters Date: Tue, 29 Apr 2014 05:00:48 -0700 Subject: [PATCH] Making `size=full` images have a shadow and be inline-block so the space next to them isn't clickable Fixes #4902 Summary: Added .phabricator-remarkup-embed-image to full size images as well Test Plan: Add an image e.g. `{F123, size=full}` and verify that it has a shadow and the space next to it isn't clickable Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: chad, epriestley, Korvin Maniphest Tasks: T4902 Differential Revision: https://secure.phabricator.com/D8858 --- .../files/remarkup/PhabricatorRemarkupRuleEmbedFile.php | 1 + webroot/rsrc/css/core/remarkup.css | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php b/src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php index fbf30d7cb9..c631d53fd4 100644 --- a/src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php +++ b/src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php @@ -98,6 +98,7 @@ final class PhabricatorRemarkupRuleEmbedFile 'width' => $file->getImageWidth(), 'height' => $file->getImageHeight(), ); + $image_class = 'phabricator-remarkup-embed-image-full'; break; case 'thumb': default: diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css index f95bcd43c1..3f65938b4a 100644 --- a/webroot/rsrc/css/core/remarkup.css +++ b/webroot/rsrc/css/core/remarkup.css @@ -271,6 +271,10 @@ box-shadow: 1px 1px 2px rgba(0, 0, 0, 0.20); } +.phabricator-remarkup-embed-image-full { + display: inline-block; +} + .phabricator-remarkup table.remarkup-table { border-collapse: separate; border-spacing: 1px;