From b69174a4c8f70d5f90d1cd703b27824e464ebcec Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 1 Jun 2017 08:17:54 -0700 Subject: [PATCH] Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction Summary: See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering. This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now. Test Plan: Changed the point value of a task, saw a feed story both before and after the patch. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12787 Differential Revision: https://secure.phabricator.com/D18059 --- .../maniphest/xaction/ManiphestTaskPointsTransaction.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php index b1c20af9e6..8953664f27 100644 --- a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php +++ b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php @@ -17,10 +17,6 @@ final class ManiphestTaskPointsTransaction $object->setPoints($value); } - public function shouldHideForFeed() { - return true; - } - public function shouldHide() { if (!ManiphestTaskPoints::getIsEnabled()) { return true;