From a8866c0b314f2a6a5414d98bf1aed9a03e676de0 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 7 Nov 2016 11:05:43 -0800 Subject: [PATCH] In Maniphest, don't render the task graph drawing if we're only showing parents/children Summary: Ref T4788. I thought I implemented this, but actualy didn't. When we're in the "mid-sized" fallback mode (graph has more than 100 nodes, but not more than than 100 parents/children), don't actually draw the graph. It's almost always uninteresting and huge. Instead, this just renders a list of direct parents, then the task, then the direct children, which is pretty straightforward. Test Plan: Set limit to 5, saw mid-sized fallback graph with no actual graph drawing. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16816 --- src/infrastructure/graph/ManiphestTaskGraph.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/infrastructure/graph/ManiphestTaskGraph.php b/src/infrastructure/graph/ManiphestTaskGraph.php index 6e92feb241..a306241f85 100644 --- a/src/infrastructure/graph/ManiphestTaskGraph.php +++ b/src/infrastructure/graph/ManiphestTaskGraph.php @@ -128,6 +128,11 @@ final class ManiphestTaskGraph 'graph-status', null, 'wide pri object-link', + )) + ->setColumnVisibility( + array( + true, + !$this->getRenderOnlyAdjacentNodes(), )); }