From a439ea7190fb01c52c6e38997faf742c982ccf28 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 17 Feb 2017 16:38:07 -0800 Subject: [PATCH] Fix a bad parameter read in hovercard Summary: I broke this at the last second in D17374. `getStrList()` doesn't read arrays. It probably should (more modern analogs do) but don't rock the boat in the leadup to the release cut. Test Plan: Hovered over a thing, saw a hovercard and no `getStrList()` error in my logs. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17383 --- .../search/controller/PhabricatorSearchHovercardController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/search/controller/PhabricatorSearchHovercardController.php b/src/applications/search/controller/PhabricatorSearchHovercardController.php index 513c8b1b24..ca83d1896d 100644 --- a/src/applications/search/controller/PhabricatorSearchHovercardController.php +++ b/src/applications/search/controller/PhabricatorSearchHovercardController.php @@ -9,7 +9,7 @@ final class PhabricatorSearchHovercardController public function handleRequest(AphrontRequest $request) { $viewer = $this->getViewer(); - $phids = $request->getStrList('phids'); + $phids = $request->getArr('phids'); // If object names are provided, look them up and pretend they were // passed as additional PHIDs. This is primarily useful for debugging,