From a13390a919a2be9771e28a9cc56d4bc23fb8c14c Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 3 Apr 2013 11:29:58 -0700 Subject: [PATCH] Flags on mobile, fix some filter-css Summary: Sets device flag on mobile, cleans up filter css a bit. Test Plan: Tested filters on homepage, maniphest, flags, uiexamples. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5559 --- src/__celerity_resource_map__.php | 78 +++++++++---------- .../PhabricatorFlagListController.php | 2 + .../PhabricatorUIListFilterExample.php | 1 + webroot/rsrc/css/aphront/list-filter-view.css | 4 +- 4 files changed, 44 insertions(+), 41 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 2e5ea05106..bb06283a11 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -767,7 +767,7 @@ celerity_register_resource_map(array( ), 'aphront-list-filter-view-css' => array( - 'uri' => '/res/b4b7589b/rsrc/css/aphront/list-filter-view.css', + 'uri' => '/res/639ea9e9/rsrc/css/aphront/list-filter-view.css', 'type' => 'css', 'requires' => array( @@ -3808,7 +3808,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '94a6751c' => + '2265745d' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -3850,7 +3850,7 @@ celerity_register_resource_map(array( 34 => 'phabricator-object-item-list-view-css', 35 => 'global-drag-and-drop-css', ), - 'uri' => '/res/pkg/94a6751c/core.pkg.css', + 'uri' => '/res/pkg/2265745d/core.pkg.css', 'type' => 'css', ), 'd95b69e5' => @@ -4040,16 +4040,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => '6b1fccc6', - 'aphront-dialog-view-css' => '94a6751c', - 'aphront-error-view-css' => '94a6751c', - 'aphront-form-view-css' => '94a6751c', - 'aphront-list-filter-view-css' => '94a6751c', - 'aphront-pager-view-css' => '94a6751c', - 'aphront-panel-view-css' => '94a6751c', - 'aphront-table-view-css' => '94a6751c', - 'aphront-tokenizer-control-css' => '94a6751c', - 'aphront-tooltip-css' => '94a6751c', - 'aphront-typeahead-control-css' => '94a6751c', + 'aphront-dialog-view-css' => '2265745d', + 'aphront-error-view-css' => '2265745d', + 'aphront-form-view-css' => '2265745d', + 'aphront-list-filter-view-css' => '2265745d', + 'aphront-pager-view-css' => '2265745d', + 'aphront-panel-view-css' => '2265745d', + 'aphront-table-view-css' => '2265745d', + 'aphront-tokenizer-control-css' => '2265745d', + 'aphront-tooltip-css' => '2265745d', + 'aphront-typeahead-control-css' => '2265745d', 'differential-changeset-view-css' => '8aaacd1b', 'differential-core-view-css' => '8aaacd1b', 'differential-inline-comment-editor' => 'e96b08f8', @@ -4063,7 +4063,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => '8aaacd1b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '94a6751c', + 'global-drag-and-drop-css' => '2265745d', 'inline-comment-summary-css' => '8aaacd1b', 'javelin-aphlict' => 'd95b69e5', 'javelin-behavior' => 'fe22443b', @@ -4135,47 +4135,47 @@ celerity_register_resource_map(array( 'javelin-util' => 'fe22443b', 'javelin-vector' => 'fe22443b', 'javelin-workflow' => 'fe22443b', - 'lightbox-attachment-css' => '94a6751c', + 'lightbox-attachment-css' => '2265745d', 'maniphest-task-summary-css' => '6b1fccc6', 'maniphest-transaction-detail-css' => '6b1fccc6', 'phabricator-busy' => 'd95b69e5', 'phabricator-content-source-view-css' => '8aaacd1b', - 'phabricator-core-buttons-css' => '94a6751c', - 'phabricator-core-css' => '94a6751c', - 'phabricator-crumbs-view-css' => '94a6751c', - 'phabricator-directory-css' => '94a6751c', + 'phabricator-core-buttons-css' => '2265745d', + 'phabricator-core-css' => '2265745d', + 'phabricator-crumbs-view-css' => '2265745d', + 'phabricator-directory-css' => '2265745d', 'phabricator-drag-and-drop-file-upload' => 'e96b08f8', 'phabricator-dropdown-menu' => 'd95b69e5', 'phabricator-file-upload' => 'd95b69e5', - 'phabricator-filetree-view-css' => '94a6751c', - 'phabricator-flag-css' => '94a6751c', - 'phabricator-form-view-css' => '94a6751c', - 'phabricator-header-view-css' => '94a6751c', - 'phabricator-jump-nav' => '94a6751c', + 'phabricator-filetree-view-css' => '2265745d', + 'phabricator-flag-css' => '2265745d', + 'phabricator-form-view-css' => '2265745d', + 'phabricator-header-view-css' => '2265745d', + 'phabricator-jump-nav' => '2265745d', 'phabricator-keyboard-shortcut' => 'd95b69e5', 'phabricator-keyboard-shortcut-manager' => 'd95b69e5', - 'phabricator-main-menu-view' => '94a6751c', + 'phabricator-main-menu-view' => '2265745d', 'phabricator-menu-item' => 'd95b69e5', - 'phabricator-nav-view-css' => '94a6751c', + 'phabricator-nav-view-css' => '2265745d', 'phabricator-notification' => 'd95b69e5', - 'phabricator-notification-css' => '94a6751c', - 'phabricator-notification-menu-css' => '94a6751c', - 'phabricator-object-item-list-view-css' => '94a6751c', + 'phabricator-notification-css' => '2265745d', + 'phabricator-notification-menu-css' => '2265745d', + 'phabricator-object-item-list-view-css' => '2265745d', 'phabricator-object-selector-css' => '8aaacd1b', 'phabricator-prefab' => 'd95b69e5', 'phabricator-project-tag-css' => '6b1fccc6', - 'phabricator-remarkup-css' => '94a6751c', + 'phabricator-remarkup-css' => '2265745d', 'phabricator-shaped-request' => 'e96b08f8', - 'phabricator-side-menu-view-css' => '94a6751c', - 'phabricator-standard-page-view' => '94a6751c', + 'phabricator-side-menu-view-css' => '2265745d', + 'phabricator-standard-page-view' => '2265745d', 'phabricator-textareautils' => 'd95b69e5', 'phabricator-tooltip' => 'd95b69e5', - 'phabricator-transaction-view-css' => '94a6751c', - 'phabricator-zindex-css' => '94a6751c', - 'sprite-apps-large-css' => '94a6751c', - 'sprite-gradient-css' => '94a6751c', - 'sprite-icon-css' => '94a6751c', - 'sprite-menu-css' => '94a6751c', - 'syntax-highlighting-css' => '94a6751c', + 'phabricator-transaction-view-css' => '2265745d', + 'phabricator-zindex-css' => '2265745d', + 'sprite-apps-large-css' => '2265745d', + 'sprite-gradient-css' => '2265745d', + 'sprite-icon-css' => '2265745d', + 'sprite-menu-css' => '2265745d', + 'syntax-highlighting-css' => '2265745d', ), )); diff --git a/src/applications/flag/controller/PhabricatorFlagListController.php b/src/applications/flag/controller/PhabricatorFlagListController.php index ee18e5b2b2..e1c4c3a832 100644 --- a/src/applications/flag/controller/PhabricatorFlagListController.php +++ b/src/applications/flag/controller/PhabricatorFlagListController.php @@ -20,6 +20,7 @@ final class PhabricatorFlagListController extends PhabricatorFlagController { $nav->setCrumbs($crumbs); $filter_form = new AphrontFormView(); + $filter_form->setNoShading(true); $filter_form->setUser($user); $filter_form->appendChild( id(new AphrontFormToggleButtonsControl()) @@ -123,6 +124,7 @@ final class PhabricatorFlagListController extends PhabricatorFlagController { $nav, array( 'title' => pht('Flags'), + 'device' => true, 'dust' => true, )); } diff --git a/src/applications/uiexample/examples/PhabricatorUIListFilterExample.php b/src/applications/uiexample/examples/PhabricatorUIListFilterExample.php index 81ce37b04c..7af6c12b71 100644 --- a/src/applications/uiexample/examples/PhabricatorUIListFilterExample.php +++ b/src/applications/uiexample/examples/PhabricatorUIListFilterExample.php @@ -17,6 +17,7 @@ final class PhabricatorUIListFilterExample extends PhabricatorUIExample { $filter = new AphrontListFilterView(); $form = new AphrontFormView(); + $form->setNoShading(true); $form->setUser($this->getRequest()->getUser()); $form ->appendChild( diff --git a/webroot/rsrc/css/aphront/list-filter-view.css b/webroot/rsrc/css/aphront/list-filter-view.css index 3e8ceb127c..187b8f1738 100644 --- a/webroot/rsrc/css/aphront/list-filter-view.css +++ b/webroot/rsrc/css/aphront/list-filter-view.css @@ -26,8 +26,8 @@ } .aphront-list-filter-view-controls .aphront-form-view { - border-width: 0; - border-bottom: 1px solid #c0c5d1; + border-left: none; + border-right: none; padding: 12px 0 6px; }