From 9db5ad3476a959f57a900e7f925f813d0405555e Mon Sep 17 00:00:00 2001 From: Austin McKinley Date: Mon, 18 Jun 2018 15:33:08 -0700 Subject: [PATCH] Allow null identities to be attached to commit objects Summary: I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out. Test Plan: Loaded commits without identity objects; did not get any errors. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D19496 --- .../repository/storage/PhabricatorRepositoryCommit.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index 7cad448e7d..abcf862b40 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -195,8 +195,9 @@ final class PhabricatorRepositoryCommit } public function attachIdentities( - PhabricatorRepositoryIdentity $author, - $committer = null) { + PhabricatorRepositoryIdentity $author = null, + PhabricatorRepositoryIdentity $committer = null) { + $this->authorIdentity = $author; $this->committerIdentity = $committer; }