From 9d6911866432e6fec34975854008bdc308d135fd Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 26 Jan 2018 08:37:13 -0800 Subject: [PATCH] Add a discovery format hint for date fields in SearchEngine UIs Summary: See PHI316. Maniphest and other applications currently have controls like `Created After: [_____]` where you just get an empty text field. Although most formats work -- including relative formats like "3 days ago" -- and we validate inputs so you get an error if you enter something nonsensical, this still isn't very user friendly. T8060 or some other approach is likely the long term of this control. In the meantime, add placeholder text to suggest that `YYYY-MM-DD` or `X days ago` will work. Test Plan: Viewed date inputs, saw placeholder text. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18942 --- src/applications/search/field/PhabricatorSearchDateField.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/search/field/PhabricatorSearchDateField.php b/src/applications/search/field/PhabricatorSearchDateField.php index 21b1627de7..41decd9503 100644 --- a/src/applications/search/field/PhabricatorSearchDateField.php +++ b/src/applications/search/field/PhabricatorSearchDateField.php @@ -4,7 +4,8 @@ final class PhabricatorSearchDateField extends PhabricatorSearchField { protected function newControl() { - return new AphrontFormTextControl(); + return id(new AphrontFormTextControl()) + ->setPlaceholder(pht('"2022-12-25" or "7 days ago"...')); } protected function getValueFromRequest(AphrontRequest $request, $key) {