From 99889a6321a75ad19de62ea5bb60b1f177ed0270 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 14 Aug 2016 06:43:22 -0700 Subject: [PATCH] Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine Summary: Ref T11473. When running `harbormaster.build.search` with a `buildables` constraint, the constraint doesn't get passed to the Query and so currently has no effect. This piece of logic was just accidentally omitted from D16356. It is probably not used anywhere today and doesn't show up in the UI, so it's easy to overlook (I missed it in review, too). Test Plan: Ran `harbormaster.build.search` with a `buildables` constraint, got expected filtering. Reviewers: yelirekim, chad Reviewed By: chad Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T11473 Differential Revision: https://secure.phabricator.com/D16395 --- .../harbormaster/query/HarbormasterBuildSearchEngine.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php b/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php index 948fea389c..4cf6a83701 100644 --- a/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php +++ b/src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php @@ -61,6 +61,10 @@ final class HarbormasterBuildSearchEngine $query->withBuildPlanPHIDs($map['plans']); } + if ($map['buildables']) { + $query->withBuildablePHIDs($map['buildables']); + } + if ($map['statuses']) { $query->withBuildStatuses($map['statuses']); }