From 818b90cf12d42a30ec73d24e484cddebd4bb42af Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 6 Sep 2017 10:11:14 -0700 Subject: [PATCH] Update Create Diff page for new Edit UI Summary: Create a diff page, new UI Test Plan: Create a diff from page Reviewers: epriestley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18529 --- .../controller/DifferentialDiffCreateController.php | 11 +++-------- src/view/phui/PHUIInfoView.php | 1 + 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php index 0e13ea08fd..36f0b86202 100644 --- a/src/applications/differential/controller/DifferentialDiffCreateController.php +++ b/src/applications/differential/controller/DifferentialDiffCreateController.php @@ -182,10 +182,10 @@ final class DifferentialDiffCreateController extends DifferentialController { ->setValue($button)); $form_box = id(new PHUIObjectBoxView()) - ->setHeaderText(pht('Diff')) + ->setHeaderText($title) ->setValidationException($validation_exception) ->setForm($form) - ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) + ->setBackground(PHUIObjectBoxView::WHITE_CONFIG) ->setFormErrors($errors); $crumbs = $this->buildApplicationCrumbs(); @@ -197,15 +197,10 @@ final class DifferentialDiffCreateController extends DifferentialController { $crumbs->addTextCrumb($title); $crumbs->setBorder(true); - $header = id(new PHUIHeaderView()) - ->setHeader($title) - ->setHeaderIcon($header_icon); - $view = id(new PHUITwoColumnView()) - ->setHeader($header) ->setFooter(array( - $info_view, $form_box, + $info_view, )); return $this->newPage() diff --git a/src/view/phui/PHUIInfoView.php b/src/view/phui/PHUIInfoView.php index 18f5af3374..161e49108b 100644 --- a/src/view/phui/PHUIInfoView.php +++ b/src/view/phui/PHUIInfoView.php @@ -59,6 +59,7 @@ final class PHUIInfoView extends AphrontTagView { } else { $icon = id(new PHUIIconView()) ->setIcon($icon); + $this->icon = $icon; } return $this;