From 7654df5d3b3f29aab36b274fb87e1865886c010a Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 24 Apr 2014 13:47:32 -0700 Subject: [PATCH] Fix insufficient loading for processing Differential mail Summary: Some actions (notably, `!accept`) require more information than we currently load. Test Plan: Piped in some `!accept` mail using `bin/mail receive-test`. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8844 --- .../mail/DifferentialRevisionMailReceiver.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/applications/differential/mail/DifferentialRevisionMailReceiver.php b/src/applications/differential/mail/DifferentialRevisionMailReceiver.php index 0568cf186c..619e8eb523 100644 --- a/src/applications/differential/mail/DifferentialRevisionMailReceiver.php +++ b/src/applications/differential/mail/DifferentialRevisionMailReceiver.php @@ -15,13 +15,13 @@ final class DifferentialRevisionMailReceiver protected function loadObject($pattern, PhabricatorUser $viewer) { $id = (int)trim($pattern, 'D'); - $results = id(new DifferentialRevisionQuery()) + return id(new DifferentialRevisionQuery()) ->setViewer($viewer) ->withIDs(array($id)) ->needReviewerStatus(true) - ->execute(); - - return head($results); + ->needReviewerAuthority(true) + ->needActiveDiffs(true) + ->executeOne(); } protected function processReceivedObjectMail(