diff --git a/src/applications/differential/landing/DifferentialLandingStrategy.php b/src/applications/differential/landing/DifferentialLandingStrategy.php index 96d948f608..c62ca2ce23 100644 --- a/src/applications/differential/landing/DifferentialLandingStrategy.php +++ b/src/applications/differential/landing/DifferentialLandingStrategy.php @@ -10,7 +10,7 @@ abstract class DifferentialLandingStrategy { /** * @return PhabricatorActionView or null. */ - abstract function createMenuItem( + public abstract function createMenuItem( PhabricatorUser $viewer, DifferentialRevision $revision, PhabricatorRepository $repository); diff --git a/src/applications/drydock/controller/DrydockController.php b/src/applications/drydock/controller/DrydockController.php index 41f82b6bfe..f8ee24f18e 100644 --- a/src/applications/drydock/controller/DrydockController.php +++ b/src/applications/drydock/controller/DrydockController.php @@ -2,7 +2,7 @@ abstract class DrydockController extends PhabricatorController { - abstract function buildSideNavView(); + public abstract function buildSideNavView(); protected function buildApplicationMenu() { return $this->buildSideNavView()->getMenu(); diff --git a/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php b/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php index 39b4dd959b..fbe70f6789 100644 --- a/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php +++ b/src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php @@ -2,7 +2,7 @@ final class PhabricatorOwnersPackageTestCase extends PhabricatorTestCase { - function testFindLongestPathsPerPackage() { + public function testFindLongestPathsPerPackage() { $rows = array( array('id' => 1, 'excluded' => 0, 'path' => 'src/'), array('id' => 1, 'excluded' => 1, 'path' => 'src/releeph/'), diff --git a/src/applications/phragment/controller/PhragmentController.php b/src/applications/phragment/controller/PhragmentController.php index 25ebd6a5ae..254444928b 100644 --- a/src/applications/phragment/controller/PhragmentController.php +++ b/src/applications/phragment/controller/PhragmentController.php @@ -201,7 +201,7 @@ abstract class PhragmentController extends PhabricatorController { ->addPropertyList($properties); } - function renderConfigurationWarningIfRequired() { + public function renderConfigurationWarningIfRequired() { $alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain'); if ($alt === null) { return id(new AphrontErrorView()) @@ -225,7 +225,7 @@ abstract class PhragmentController extends PhabricatorController { * are configured otherwise (because the Files app does not support showing * the info page to viewers who are not logged in). */ - function isCorrectlyConfigured() { + public function isCorrectlyConfigured() { $alt = PhabricatorEnv::getEnvConfig('security.alternate-file-domain'); return $alt !== null; } diff --git a/src/applications/phragment/controller/PhragmentRevertController.php b/src/applications/phragment/controller/PhragmentRevertController.php index 9b13a79277..84e8cbb71e 100644 --- a/src/applications/phragment/controller/PhragmentRevertController.php +++ b/src/applications/phragment/controller/PhragmentRevertController.php @@ -64,7 +64,7 @@ final class PhragmentRevertController extends PhragmentController { return $this->createDialog($fragment, $version); } - function createDialog( + public function createDialog( PhragmentFragment $fragment, PhragmentFragmentVersion $version) { diff --git a/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php b/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php index 26591d4aef..715280a2c2 100644 --- a/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php +++ b/src/applications/phragment/controller/PhragmentSnapshotDeleteController.php @@ -36,7 +36,7 @@ final class PhragmentSnapshotDeleteController extends PhragmentController { return $this->createDialog(); } - function createDialog() { + public function createDialog() { $request = $this->getRequest(); $viewer = $request->getUser(); diff --git a/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php b/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php index 5d45842ebe..18d7df6a5a 100644 --- a/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php +++ b/src/applications/phragment/controller/PhragmentSnapshotPromoteController.php @@ -162,7 +162,7 @@ final class PhragmentSnapshotPromoteController extends PhragmentController { return $this->createDialog(); } - function createDialog() { + public function createDialog() { $request = $this->getRequest(); $viewer = $request->getUser(); diff --git a/src/infrastructure/log/PhabricatorAccessLog.php b/src/infrastructure/log/PhabricatorAccessLog.php index 2b77d144cd..5b6d37d74f 100644 --- a/src/infrastructure/log/PhabricatorAccessLog.php +++ b/src/infrastructure/log/PhabricatorAccessLog.php @@ -2,7 +2,7 @@ final class PhabricatorAccessLog { - static $log; + private static $log; public static function init() { // NOTE: This currently has no effect, but some day we may reuse PHP diff --git a/src/infrastructure/log/PhabricatorSSHLog.php b/src/infrastructure/log/PhabricatorSSHLog.php index 12b8001b5a..9f9f75b41b 100644 --- a/src/infrastructure/log/PhabricatorSSHLog.php +++ b/src/infrastructure/log/PhabricatorSSHLog.php @@ -2,7 +2,7 @@ final class PhabricatorSSHLog extends Phobject { - static $log; + private static $log; public static function getLog() { if (!self::$log) { diff --git a/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php b/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php index 282cbbd822..0eefe68069 100644 --- a/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php +++ b/src/infrastructure/storage/patch/PhabricatorSQLPatchList.php @@ -2,8 +2,8 @@ abstract class PhabricatorSQLPatchList { - abstract function getNamespace(); - abstract function getPatches(); + public abstract function getNamespace(); + public abstract function getPatches(); /** * Examine a directory for `.php` and `.sql` files and build patch