From 5b9d8aeae70118d1330b1d87717efd70c51d1f42 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 25 Feb 2016 03:07:47 -0800 Subject: [PATCH] Fix two issues with callsign-free repositories Summary: Ref T4245. These callsites don't quite do the right thing if a repository has no callsign. See also . Test Plan: Made a comment on a commit in a repository with no callsign. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4245 Differential Revision: https://secure.phabricator.com/D15344 --- .../audit/controller/PhabricatorAuditAddCommentController.php | 4 +--- .../diffusion/controller/DiffusionExternalController.php | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/applications/audit/controller/PhabricatorAuditAddCommentController.php b/src/applications/audit/controller/PhabricatorAuditAddCommentController.php index b4bb950806..5e50b2ae9d 100644 --- a/src/applications/audit/controller/PhabricatorAuditAddCommentController.php +++ b/src/applications/audit/controller/PhabricatorAuditAddCommentController.php @@ -82,9 +82,7 @@ final class PhabricatorAuditAddCommentController $draft->delete(); } - $monogram = $commit->getRepository()->getMonogram(); - $identifier = $commit->getCommitIdentifier(); - $uri = '/'.$monogram.$identifier; + $uri = $commit->getURI(); return id(new AphrontRedirectResponse())->setURI($uri); } diff --git a/src/applications/diffusion/controller/DiffusionExternalController.php b/src/applications/diffusion/controller/DiffusionExternalController.php index 09687f11d0..07a131c826 100644 --- a/src/applications/diffusion/controller/DiffusionExternalController.php +++ b/src/applications/diffusion/controller/DiffusionExternalController.php @@ -103,7 +103,7 @@ final class DiffusionExternalController extends DiffusionController { array( 'href' => $href, ), - $commit->getMonogram()), + $commit->getURI()), $commit->loadCommitData()->getSummary(), ); }