From 5a5c456264af6e56fdb99167d7c76b4f52a5ee99 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sun, 7 Apr 2024 21:59:25 +0200 Subject: [PATCH] Correct docs of PhabricatorPHIDType::getAllTypesForApplication() Summary: The signature and return type of the `getAllTypesForApplication()` function differed from its docs. Test Plan: Carefully read the code of the function and compare it to the `getAllInstalledTypes()` function above from which the docs were incorrectly copied. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25572 --- src/applications/phid/type/PhabricatorPHIDType.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/applications/phid/type/PhabricatorPHIDType.php b/src/applications/phid/type/PhabricatorPHIDType.php index f15df7f886..6a283a7d08 100644 --- a/src/applications/phid/type/PhabricatorPHIDType.php +++ b/src/applications/phid/type/PhabricatorPHIDType.php @@ -207,11 +207,10 @@ abstract class PhabricatorPHIDType extends Phobject { /** - * Get all PHID types of applications installed for a given viewer. + * Get all PHID types of an application. * - * @param PhabricatorUser Viewing user. - * @return dict Map of constants to installed - * types. + * @param string Class name of an application + * @return dict Map of constants of application */ public static function getAllTypesForApplication( string $application) {