From 54409e7716499edcd653ea112b93e6515fe0b91b Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 11 May 2016 15:30:57 -0700 Subject: [PATCH] Fix an issue with TextAreaEditField affecting Paste Summary: Fixes T10952. Fixes T10930. I didn't implement this method correctly when I expanded this field for repositories. Test Plan: Edited a paste without warnings. Reviewers: avivey, chad Reviewed By: chad Maniphest Tasks: T10930, T10952 Differential Revision: https://secure.phabricator.com/D15892 --- .../transactions/editfield/PhabricatorTextAreaEditField.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/applications/transactions/editfield/PhabricatorTextAreaEditField.php b/src/applications/transactions/editfield/PhabricatorTextAreaEditField.php index 4c07b31e54..4d4e3a75b8 100644 --- a/src/applications/transactions/editfield/PhabricatorTextAreaEditField.php +++ b/src/applications/transactions/editfield/PhabricatorTextAreaEditField.php @@ -51,7 +51,11 @@ final class PhabricatorTextAreaEditField protected function getValueForControl() { $value = $this->getValue(); - return implode("\n", $value); + if ($this->getIsStringList()) { + return implode("\n", $value); + } else { + return $value; + } } protected function newConduitParameterType() {