diff --git a/src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php b/src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php index 5c2b498022..01f0f1fa9c 100644 --- a/src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php +++ b/src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php @@ -1,7 +1,7 @@ getSourcePath().$file) && - $unit_result['result'] === - DifferentialUnitTestResult::RESULT_POSTPONED) { - $unit_result['name'] = $name; + if ($unit_result['name'] === $name) { + $unit_result['file'] = $file; $unit_result['result'] = $result; $unit_result['userdata'] = $message; $unit_status = $result; @@ -89,10 +87,15 @@ extends ConduitAPIMethod { } unset($unit_result); + // If the test result doesn't exist, just add it. if (!$unit_status) { - phlog("Could not update test results: {$diff_id} {$file} {$name}". - " {$result} {$message}"); - return; + $unit_result = array(); + $unit_result['file'] = $file; + $unit_result['name'] = $name; + $unit_result['result'] = $result; + $unit_result['userdata'] = $message; + $unit_status = $result; + $unit_results[] = $unit_result; } $diff_property->setData($unit_results); diff --git a/src/applications/conduit/method/differential/updateunitresults/__init__.php b/src/applications/conduit/method/differential/updateunitresults/__init__.php index 405d942cbc..d0e80055ee 100644 --- a/src/applications/conduit/method/differential/updateunitresults/__init__.php +++ b/src/applications/conduit/method/differential/updateunitresults/__init__.php @@ -13,7 +13,6 @@ phutil_require_module('phabricator', 'applications/differential/constants/unitte phutil_require_module('phabricator', 'applications/differential/storage/diff'); phutil_require_module('phabricator', 'applications/differential/storage/diffproperty'); -phutil_require_module('phutil', 'error'); phutil_require_module('phutil', 'utils');