From 44b41a94ae507dbc49778852c5c5dc19c5314b9a Mon Sep 17 00:00:00 2001 From: Anirudh Sanjeev Date: Sat, 8 Mar 2014 06:37:16 -0800 Subject: [PATCH] Add a note suggesting restarting daemons for feed.http-hooks Summary: I was trying to set up a http hook, but despite setting the config, the endpoint wasn't getting a request. I was advised on IRC by balpert to restart my daemons and it worked great after I did that. Since this information isn't in the documentation, I am adding it to the description of the option, so it helps the next person. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran, spicyj Differential Revision: https://secure.phabricator.com/D8447 --- conf/default.conf.php | 3 ++- src/applications/feed/config/PhabricatorFeedConfigOptions.php | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/conf/default.conf.php b/conf/default.conf.php index f533093c62..a4f034972c 100644 --- a/conf/default.conf.php +++ b/conf/default.conf.php @@ -941,7 +941,8 @@ return array( // task will be created for each uri that posts the story data to the uri. // Daemons automagically retry failures 100 times, waiting $fail_count * 60s // between each subsequent failure. Be sure to keep the daemon console - // (/daemon/) open while developing and testing your end points. + // (/daemon/) open while developing and testing your end points. You may need + // to restart your daemons to start sending http requests. // // NOTE: URIs are not validated, the URI must return http status 200 within // 30 seconds, and no permission checks are performed. diff --git a/src/applications/feed/config/PhabricatorFeedConfigOptions.php b/src/applications/feed/config/PhabricatorFeedConfigOptions.php index 4361bc2ed1..6a5803e3bf 100644 --- a/src/applications/feed/config/PhabricatorFeedConfigOptions.php +++ b/src/applications/feed/config/PhabricatorFeedConfigOptions.php @@ -38,7 +38,8 @@ final class PhabricatorFeedConfigOptions "story data to the uri. Daemons automagically retry failures 100 ". "times, waiting \$fail_count * 60s between each subsequent ". "failure. Be sure to keep the daemon console (/daemon/) open ". - "while developing and testing your end points.\n\n". + "while developing and testing your end points. You may need to". + "restart your daemons to start sending http requests.\n\n". "NOTE: URIs are not validated, the URI must return http status ". "200 within 30 seconds, and no permission checks are performed.")), );