From 3fd24004d241d574f1c5ce7327dba8ac502b6609 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Thu, 24 Apr 2025 18:57:19 +0200 Subject: [PATCH] Remove vendor-prefixed background-clip CSS syntax Summary: `-moz-background-clip: padding` syntax was only supported until Firefox 3.6 according to https://web.archive.org/web/20130827100732/https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip. Firefox 4.0 released 03/2011 supports standard `background-clip: padding-box`. The same docs also imply that `-webkit-background-clip: padding-box` currently used by Phorge was never supported by browsers. Per https://caniuse.com/mdn-css_properties_background-clip_padding-box, Chrome 4 released 10/2010 supports standard `background-clip: padding-box`. Compare current `webroot/rsrc/css/phui/phui-image-mask.css` which does not have this old vendor-prefixed syntax. Test Plan: * Open the Conpherence top bar dropdown, select "Persistent Chat", see that its `.jx-scrollbar-handle` based scrollbar still works as expected. * Read CSS docs. Probably install ancient browser versions if you don't trust documentation. Try https://jigsaw.w3.org/css-validator/ and don't spot issues. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25970 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/application/base/standard-page-view.css | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 988c975d2b..c52559aabb 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => '3144a5e2', 'conpherence.pkg.js' => '020aebcf', - 'core.pkg.css' => '4fe809a5', + 'core.pkg.css' => 'bb6430bf', 'core.pkg.js' => '086da722', 'dark-console.pkg.js' => '187792c2', 'differential.pkg.css' => '91ac6214', @@ -41,7 +41,7 @@ return array( 'rsrc/css/application/base/main-menu-view.css' => '741a6bba', 'rsrc/css/application/base/notification-menu.css' => '4df1ee30', 'rsrc/css/application/base/phui-theme.css' => '35883b37', - 'rsrc/css/application/base/standard-page-view.css' => '6267874d', + 'rsrc/css/application/base/standard-page-view.css' => 'c2aa85b9', 'rsrc/css/application/conduit/conduit-api.css' => 'ce2cfc41', 'rsrc/css/application/config/config-options.css' => '16c920ae', 'rsrc/css/application/config/config-template.css' => '20babf50', @@ -803,7 +803,7 @@ return array( 'phabricator-shaped-request' => '995f5102', 'phabricator-slowvote-css' => '1694baed', 'phabricator-source-code-view-css' => 'e382316a', - 'phabricator-standard-page-view' => '6267874d', + 'phabricator-standard-page-view' => 'c2aa85b9', 'phabricator-textareautils' => 'f340a484', 'phabricator-title' => '43bc9360', 'phabricator-tooltip' => '83754533', diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css index 2938796bff..e22ad4fada 100644 --- a/webroot/rsrc/css/application/base/standard-page-view.css +++ b/webroot/rsrc/css/application/base/standard-page-view.css @@ -170,8 +170,7 @@ a.handle-status-closed:hover { -moz-transition: opacity 0.2s linear; transition: opacity 0.2s linear; background: #6c6e71; - -webkit-background-clip: padding-box; - -moz-background-clip: padding; + background-clip: padding-box; } .jx-scrollbar-bar:hover .jx-scrollbar-handle {