From 2f7057ad99e416a7ecf7f1c4856beb281f0db5e7 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 30 Oct 2013 17:20:06 -0700
Subject: [PATCH] Preserve linebreaks again in Summary / Test Plan for
 revisions

Summary:
I pulled these into the property list recently, which made them more consistent, but that dropped "preserve linebreaks". Since these usually come from the CLI, render with linebreaks preserved.

@csilvers, you'll need to `bin/cache purge --purge-remarkup` after this if you want to fix existing revisions.

Test Plan: Made a revision with some poetry, saw poetry preserved.

Reviewers: btrahan, csilvers

Reviewed By: btrahan

CC: csilvers, aran

Differential Revision: https://secure.phabricator.com/D7464
---
 .../view/DifferentialRevisionDetailView.php            | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/applications/differential/view/DifferentialRevisionDetailView.php b/src/applications/differential/view/DifferentialRevisionDetailView.php
index 47d021a033..4093061efb 100644
--- a/src/applications/differential/view/DifferentialRevisionDetailView.php
+++ b/src/applications/differential/view/DifferentialRevisionDetailView.php
@@ -118,8 +118,9 @@ final class DifferentialRevisionDetailView extends AphrontView {
       $properties->addSectionHeader(pht('Summary'));
       $properties->addTextContent(
         PhabricatorMarkupEngine::renderOneObject(
-          id(new PhabricatorMarkupOneOff())->setContent(
-            $revision->getSummary()),
+          id(new PhabricatorMarkupOneOff())
+            ->setPreserveLinebreaks(true)
+            ->setContent($revision->getSummary()),
           'default',
           $user));
     }
@@ -128,8 +129,9 @@ final class DifferentialRevisionDetailView extends AphrontView {
       $properties->addSectionHeader(pht('Test Plan'));
       $properties->addTextContent(
         PhabricatorMarkupEngine::renderOneObject(
-          id(new PhabricatorMarkupOneOff())->setContent(
-            $revision->getTestPlan()),
+          id(new PhabricatorMarkupOneOff())
+            ->setPreserveLinebreaks(true)
+            ->setContent($revision->getTestPlan()),
           'default',
           $user));
     }