From 2c855a89934898913d7dcdd15ac9629e1b0ec0b8 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 7 Jan 2015 07:33:52 +1100 Subject: [PATCH] Fix method visibility for `PhabricatorConfigStorageSchema` methods Summary: Ref T6822. Test Plan: Visual inspection. These methods are only called from within the `PhabricatorConfigStorageSchema` class. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6822 Differential Revision: https://secure.phabricator.com/D11247 --- .../config/schema/PhabricatorConfigColumnSchema.php | 2 +- .../config/schema/PhabricatorConfigDatabaseSchema.php | 2 +- src/applications/config/schema/PhabricatorConfigKeySchema.php | 2 +- .../config/schema/PhabricatorConfigServerSchema.php | 2 +- src/applications/config/schema/PhabricatorConfigTableSchema.php | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/applications/config/schema/PhabricatorConfigColumnSchema.php b/src/applications/config/schema/PhabricatorConfigColumnSchema.php index dc60353233..091b5caef9 100644 --- a/src/applications/config/schema/PhabricatorConfigColumnSchema.php +++ b/src/applications/config/schema/PhabricatorConfigColumnSchema.php @@ -121,7 +121,7 @@ final class PhabricatorConfigColumnSchema return 0; } - public function compareToSimilarSchema( + protected function compareToSimilarSchema( PhabricatorConfigStorageSchema $expect) { $issues = array(); diff --git a/src/applications/config/schema/PhabricatorConfigDatabaseSchema.php b/src/applications/config/schema/PhabricatorConfigDatabaseSchema.php index f67d062c27..bf0af3f480 100644 --- a/src/applications/config/schema/PhabricatorConfigDatabaseSchema.php +++ b/src/applications/config/schema/PhabricatorConfigDatabaseSchema.php @@ -29,7 +29,7 @@ final class PhabricatorConfigDatabaseSchema return $this->getTables(); } - public function compareToSimilarSchema( + protected function compareToSimilarSchema( PhabricatorConfigStorageSchema $expect) { $issues = array(); diff --git a/src/applications/config/schema/PhabricatorConfigKeySchema.php b/src/applications/config/schema/PhabricatorConfigKeySchema.php index 5fe11842de..b30a3641e9 100644 --- a/src/applications/config/schema/PhabricatorConfigKeySchema.php +++ b/src/applications/config/schema/PhabricatorConfigKeySchema.php @@ -83,7 +83,7 @@ final class PhabricatorConfigKeySchema return $size; } - public function compareToSimilarSchema( + protected function compareToSimilarSchema( PhabricatorConfigStorageSchema $expect) { $issues = array(); diff --git a/src/applications/config/schema/PhabricatorConfigServerSchema.php b/src/applications/config/schema/PhabricatorConfigServerSchema.php index 2f3557fe6f..b8b21fe919 100644 --- a/src/applications/config/schema/PhabricatorConfigServerSchema.php +++ b/src/applications/config/schema/PhabricatorConfigServerSchema.php @@ -27,7 +27,7 @@ final class PhabricatorConfigServerSchema return $this->getDatabases(); } - public function compareToSimilarSchema( + protected function compareToSimilarSchema( PhabricatorConfigStorageSchema $expect) { return array(); } diff --git a/src/applications/config/schema/PhabricatorConfigTableSchema.php b/src/applications/config/schema/PhabricatorConfigTableSchema.php index c7b0888705..b05e7e1e8e 100644 --- a/src/applications/config/schema/PhabricatorConfigTableSchema.php +++ b/src/applications/config/schema/PhabricatorConfigTableSchema.php @@ -62,7 +62,7 @@ final class PhabricatorConfigTableSchema return $this->collation; } - public function compareToSimilarSchema( + protected function compareToSimilarSchema( PhabricatorConfigStorageSchema $expect) { $issues = array();