From 28155a51150d62462848e74a35d542fa0761de62 Mon Sep 17 00:00:00 2001 From: tuomaspelkonen Date: Thu, 14 Apr 2011 12:52:28 -0700 Subject: [PATCH] Fixed Differential quotes rendering. (phabricator) Summary: When quoting someone's text in differential, the text was not properly rendered. Now the quoted text is rendered nicely and it's easy to locate. Test Plan: Disabled the inline cache, Checked that quotes in D211086 are rendered correctly. Started writing a new comment starting with '>' and made sure the new comment was rendered correctly while writing it. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, tuomaspelkonen, epriestley Differential Revision: 138 --- .../parser/markup/DifferentialMarkupEngineFactory.php | 1 + src/applications/differential/parser/markup/__init__.php | 1 + webroot/rsrc/css/core/remarkup.css | 8 ++++++++ 3 files changed, 10 insertions(+) diff --git a/src/applications/differential/parser/markup/DifferentialMarkupEngineFactory.php b/src/applications/differential/parser/markup/DifferentialMarkupEngineFactory.php index a65712a83a..15ed808532 100644 --- a/src/applications/differential/parser/markup/DifferentialMarkupEngineFactory.php +++ b/src/applications/differential/parser/markup/DifferentialMarkupEngineFactory.php @@ -38,6 +38,7 @@ class DifferentialMarkupEngineFactory { $rules[] = new PhutilRemarkupRuleItalic(); $blocks = array(); + $blocks[] = new PhutilRemarkupEngineRemarkupQuotesBlockRule(); $blocks[] = new PhutilRemarkupEngineRemarkupHeaderBlockRule(); $blocks[] = new PhutilRemarkupEngineRemarkupListBlockRule(); $blocks[] = new PhutilRemarkupEngineRemarkupCodeBlockRule(); diff --git a/src/applications/differential/parser/markup/__init__.php b/src/applications/differential/parser/markup/__init__.php index 4df4f32823..3bd80e23da 100644 --- a/src/applications/differential/parser/markup/__init__.php +++ b/src/applications/differential/parser/markup/__init__.php @@ -16,6 +16,7 @@ phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupcode') phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupdefault'); phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupheader'); phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkuplist'); +phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupquotes'); phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/bold'); phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/escapehtml'); phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/escaperemarkup'); diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css index 26eaaf57cb..3a37b64be1 100644 --- a/webroot/rsrc/css/core/remarkup.css +++ b/webroot/rsrc/css/core/remarkup.css @@ -40,3 +40,11 @@ .phabricator-remarkup h2 { margin: .75em 0 .5em; } + +.phabricator-remarkup blockquote { + border-left: 1px solid #AAAAAA; + color: #333333; + font-style: italic; + margin: .5em 0em; + padding: .25em 1em; +}