diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index 3a535f0b8a..eb31ff9a18 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -222,10 +222,6 @@ abstract class PhabricatorController extends AphrontController { $page->setDeviceReady(true); } - if (idx($options, 'fonts')) { - $page->setExtraFonts(true); - } - $page->setShowChrome(idx($options, 'chrome', true)); $application_menu = $this->buildApplicationMenu(); diff --git a/src/applications/diviner/controller/DivinerAtomController.php b/src/applications/diviner/controller/DivinerAtomController.php index 5b4d2207a4..956cf12e2e 100644 --- a/src/applications/diviner/controller/DivinerAtomController.php +++ b/src/applications/diviner/controller/DivinerAtomController.php @@ -249,7 +249,6 @@ final class DivinerAtomController extends DivinerController { array( 'title' => $symbol->getTitle(), 'device' => true, - 'fonts' => true, )); } diff --git a/src/applications/diviner/controller/DivinerBookController.php b/src/applications/diviner/controller/DivinerBookController.php index c9552cd530..ea67efb39b 100644 --- a/src/applications/diviner/controller/DivinerBookController.php +++ b/src/applications/diviner/controller/DivinerBookController.php @@ -92,7 +92,6 @@ final class DivinerBookController extends DivinerController { array( 'title' => $book->getTitle(), 'device' => true, - 'fonts' => true, )); } diff --git a/src/applications/diviner/controller/DivinerFindController.php b/src/applications/diviner/controller/DivinerFindController.php index 16ac0e1372..56b6af89b7 100644 --- a/src/applications/diviner/controller/DivinerFindController.php +++ b/src/applications/diviner/controller/DivinerFindController.php @@ -86,7 +86,6 @@ final class DivinerFindController extends DivinerController { array( 'title' => array(pht('Find'), pht('"%s"', $query_text)), 'device' => true, - 'fonts' => true, )); } diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php index 615a10fabd..f4cd10be14 100644 --- a/src/view/page/PhabricatorStandardPageView.php +++ b/src/view/page/PhabricatorStandardPageView.php @@ -12,7 +12,6 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { private $glyph; private $menuContent; private $showChrome = true; - private $extraFonts; private $disableConsole; private $pageObjects = array(); private $applicationMenu; @@ -58,15 +57,6 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { return $this->showChrome; } - public function setExtraFonts($extra) { - $this->extraFonts = $extra; - return $this; - } - - public function getExtraFonts() { - return $this->extraFonts; - } - public function appendPageObjects(array $objs) { foreach ($objs as $obj) { $this->pageObjects[] = $obj; @@ -243,16 +233,8 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { $response = CelerityAPI::getStaticResourceResponse(); - $fonts = null; - if ($this->getExtraFonts()) { - $fonts = hsprintf(""); - } - return hsprintf( - '%s%s%s', parent::getHead(), - $fonts, phutil_safe_html($monospaced), phutil_safe_html($monospaced_win), $response->renderSingleResource('javelin-magical-init', 'phabricator')); diff --git a/src/view/phui/PHUIDocumentView.php b/src/view/phui/PHUIDocumentView.php index 2b6feb7036..00d4853421 100644 --- a/src/view/phui/PHUIDocumentView.php +++ b/src/view/phui/PHUIDocumentView.php @@ -75,6 +75,12 @@ final class PHUIDocumentView extends AphrontTagView { require_celerity_resource('phui-fontkit-css'); } + switch ($this->fontKit) { + case self::FONT_SOURCE_SANS: + require_celerity_resource('font-source-sans-pro'); + break; + } + $classes = array(); $classes[] = 'phui-document-view'; if ($this->offset) {