From 1f2028adf0f5dae6962d2ed01d7399796f25c6dd Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Fri, 6 Apr 2012 01:32:05 -0700
Subject: [PATCH] Render valid HTML

Summary: Also delete some dead code.

Test Plan: /D1

Reviewers: tuomaspelkonen, epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2120
---
 .../DifferentialDiffTableOfContentsView.php              | 9 +++++++--
 .../commitchangetable/DiffusionCommitChangeTableView.php | 3 ---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/applications/differential/view/difftableofcontents/DifferentialDiffTableOfContentsView.php b/src/applications/differential/view/difftableofcontents/DifferentialDiffTableOfContentsView.php
index 5a95105e40..2dba398942 100644
--- a/src/applications/differential/view/difftableofcontents/DifferentialDiffTableOfContentsView.php
+++ b/src/applications/differential/view/difftableofcontents/DifferentialDiffTableOfContentsView.php
@@ -174,8 +174,13 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
 
       $rows[] =
         '<tr>'.
-          '<td class="differential-toc-char" title='.$chartitle.'>'.$char.
-          '</td>'.
+          phutil_render_tag(
+            'td',
+            array(
+              'class' => 'differential-toc-char',
+              'title' => $chartitle,
+            ),
+            $char).
           '<td class="differential-toc-prop">'.$pchar.'</td>'.
           '<td class="differential-toc-ftype">'.$desc.'</td>'.
           '<td class="differential-toc-file">'.$link.$lines.'</td>'.
diff --git a/src/applications/diffusion/view/commitchangetable/DiffusionCommitChangeTableView.php b/src/applications/diffusion/view/commitchangetable/DiffusionCommitChangeTableView.php
index ec910c943b..89e170ed02 100644
--- a/src/applications/diffusion/view/commitchangetable/DiffusionCommitChangeTableView.php
+++ b/src/applications/diffusion/view/commitchangetable/DiffusionCommitChangeTableView.php
@@ -34,9 +34,6 @@ final class DiffusionCommitChangeTableView extends DiffusionView {
     // TODO: Copy Away and Move Away are rendered junkily still.
 
     foreach ($this->pathChanges as $change) {
-      $change_verb = DifferentialChangeType::getFullNameForChangeType(
-        $change->getChangeType());
-
       $path = $change->getPath();
       $hash = substr(md5($path), 0, 8);
       if ($change->getFileType() == DifferentialChangeType::FILE_DIRECTORY) {