From 198bf1198dafa819f7a96e226c145562f1fed97a Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 27 Oct 2015 12:06:48 -0700 Subject: [PATCH] Fix "Accepted" status constant in landing Summary: I didn't test the positive version of this -- the constant has value `2` but when we read it from the database it's `"2"` or whatever. Just do this for now and maybe someday we'll use strings. Test Plan: will do production things Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14352 --- .../drydock/operation/DrydockLandRepositoryOperation.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/drydock/operation/DrydockLandRepositoryOperation.php b/src/applications/drydock/operation/DrydockLandRepositoryOperation.php index 6da4c2ae5d..48a3e8075f 100644 --- a/src/applications/drydock/operation/DrydockLandRepositoryOperation.php +++ b/src/applications/drydock/operation/DrydockLandRepositoryOperation.php @@ -234,7 +234,7 @@ final class DrydockLandRepositoryOperation } $status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED; - if ($revision->getStatus() !== $status_accepted) { + if ($revision->getStatus() != $status_accepted) { return array( 'title' => pht('Revision Not Accepted'), 'body' => pht(